-
Notifications
You must be signed in to change notification settings - Fork 3.8k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
pkg/ccl/serverccl/statusccl/statusccl_test: TestTenantStatusAPI failed #99770
Comments
pkg/ccl/serverccl/statusccl/statusccl_test.TestTenantStatusAPI failed with artifacts on release-23.1 @ a34af06d8e7230e4052db80d55da21a06013f81b:
Parameters: Same failure on other branches
|
pkg/ccl/serverccl/statusccl/statusccl_test.TestTenantStatusAPI failed with artifacts on release-23.1 @ aec78f33d45a8376a0ecec885688bae60dbfb85c:
Parameters: Same failure on other branches
|
100817: statusccl: fix flaky TestTenantStatusAPI txn_id_resolution r=j82w a=j82w The txn resolution add a txn id to the cache, and then in a separate call updates the txn id with the fingerprint. The test previously assumed if there was a record it would always have a valid fingerprint, but that is not true. The test is modified to add retry logic to wait for the fingerprint to be updated. The retry time was set to always be 1 minute, because SucceedsSoon only waits 5 seconds for race scenario which is not enough time for the resolution to complete. Epic: none part of: #99770 Release note: none 100943: licenses: Update BSL change date for master/23/2 r=e-mbrown a=e-mbrown This commit updates the BSL license for master/23.2. Epic: REL-286 Release note: None Co-authored-by: j82w <[email protected]> Co-authored-by: e-mbrown <[email protected]>
pkg/ccl/serverccl/statusccl/statusccl_test.TestTenantStatusAPI failed with artifacts on release-23.1 @ 82fddc52747a86c696a1f77a85abc25d05858cc1:
Parameters: Same failure on other branches
|
102726: sql: fixes flaky TestSQLStatsCompactor r=j82w a=j82w The TestSQLStatsCompactor validates the amount of scans done by the compactor test. The new activity update job will also do a scan on the stats table which can cause the count to be off. This disables the update job to avoid any conflict. The test ran for 15k run under stress with deadlock detection without any failures. tenant_span_stats test is being skipped under deadlock, because it causes a race condition resulting in a flaky. Epic: none closes: #102022 Informs: #99770 Release note: None Co-authored-by: j82w <[email protected]>
pkg/ccl/serverccl/statusccl/statusccl_test.TestTenantStatusAPI failed with artifacts on release-23.1 @ fbea48d5cd399ab1889ae8ce76b11f521d914686:
Parameters: Same failure on other branches
|
pkg/ccl/serverccl/statusccl/statusccl_test.TestTenantStatusAPI failed with artifacts on release-23.1 @ fbea48d5cd399ab1889ae8ce76b11f521d914686:
Parameters: Same failure on other branches
|
pkg/ccl/serverccl/statusccl/statusccl_test.TestTenantStatusAPI failed with artifacts on release-23.1 @ 26713f81a397d13db4f2257eaa0f6bb70d1a7cb3:
Parameters: Same failure on other branches
|
pkg/ccl/serverccl/statusccl/statusccl_test.TestTenantStatusAPI failed with artifacts on release-23.1 @ 4226a83871bbce776bc9389fca5cf084b4bb7632:
Parameters: Same failure on other branches
|
pkg/ccl/serverccl/statusccl/statusccl_test.TestTenantStatusAPI failed with artifacts on release-23.1 @ 4226a83871bbce776bc9389fca5cf084b4bb7632:
Parameters: Same failure on other branches
|
pkg/ccl/serverccl/statusccl/statusccl_test.TestTenantStatusAPI failed with artifacts on release-23.1 @ b4533bdbc4b478f0ad311bad80b62bd072cf61cf:
Parameters: Same failure on other branches
|
pkg/ccl/serverccl/statusccl/statusccl_test.TestTenantStatusAPI failed with artifacts on release-23.1 @ b4533bdbc4b478f0ad311bad80b62bd072cf61cf:
Parameters: Same failure on other branches
|
pkg/ccl/serverccl/statusccl/statusccl_test.TestTenantStatusAPI failed with artifacts on release-23.1 @ 4c24848334fa068ae0eef950c687b42497bb7bd0:
Parameters: Same failure on other branches
|
pkg/ccl/serverccl/statusccl/statusccl_test.TestTenantStatusAPI failed with artifacts on release-23.1 @ a84cfb9d8fb0f3da6b0b9c4197caa4e79e2ca968:
Parameters: Same failure on other branches
|
pkg/ccl/serverccl/statusccl/statusccl_test.TestTenantStatusAPI failed with artifacts on release-23.1 @ cff1bce2e6bb6aaf6c3619765749fc31af4de5b3:
Parameters: Same failure on other branches
|
I've also seen this failure in CI: https://teamcity.cockroachdb.com/viewLog.html?buildId=10567081&buildTypeId=Cockroach_BazelEssentialCi
|
Informs cockroachdb#92382, cockroachdb#99770, cockroachdb#99559 Epic: none Release note: None
100083: kvserver: record metrics for ErrProposalDropped r=pavelkalinnikov a=tbg Touches #100096. Epic: none Release note: None 105093: sql: use datum alloc for crdb_internal stmt stats rows r=dt a=dt Happened to observe a cluster running a customer test suite which included a query that inspected stmt stats often, causing the CRDB node to spend a considerable amount of CPU time in production of the stmt stats vtable, in particular allocating (and then GC'ing) individual datums, especially given how wide this table has become with the addition of storage stats. This change uses a datum allocator to produce those rows to reduce the number of separate allocations from the runtime. Release note: none. Epic: none. 105197: statusccl: skip flaky TenantStatusAPI tests r=zachlite a=zachlite Informs #92382, #99770, #99559 Epic: none Release note: None Co-authored-by: Tobias Grieger <[email protected]> Co-authored-by: David Taylor <[email protected]> Co-authored-by: Zach Lite <[email protected]>
Informs cockroachdb#92382, cockroachdb#99770, cockroachdb#99559 Epic: none Release note: None
pkg/ccl/serverccl/statusccl/statusccl_test.TestTenantStatusAPI failed with artifacts on release-23.1 @ 503ea5248f37ee180a6c82ece0a41bf05c833407:
Same failure on other branches
|
This commit fixes flaky behavior while running `TestSpanStatsFanOut` and `TestTenantSpanStats` under stress. Both tests have been updated to ensure the following behavior: - The tests make sure range splits occur before proceeding. - The tests will retry their assertions to give the new key-value pairs time to replicate. Additionally, `NewTestTenantHelper` was updated to accept a parameter for the number of nodes in the test host cluster. `TestTenantSpanStats` now uses a 3-node cluster to test a real fan-out. Resolves cockroachdb#99770 Resolves cockroachdb#99559 Epic:none Release note: None
106551: server, statusccl: de-flake span stats fan-out tests r=zachlite a=zachlite This commit fixes flaky behavior while running `TestSpanStatsFanOut` and `TestTenantSpanStats` under stress. Both tests have been updated to ensure the following behavior: - The tests make sure range splits occur before proceeding. - The tests will retry their assertions to give the new key-value pairs time to replicate. Additionally, `NewTestTenantHelper` was updated to accept a parameter for the number of nodes in the test host cluster. `TestTenantSpanStats` now uses a 3-node cluster to test a real fan-out. Resolves #99770 Resolves #99559 Epic:none Release note: None 106627: diagnosticsccl: unskip TestTenantReport r=yuzefovich a=yuzefovich The flakiness of the test was resolved by #106053. Addresses: #101622. Epic: None Release note: None Co-authored-by: zachlite <[email protected]> Co-authored-by: Yahor Yuzefovich <[email protected]>
This commit fixes flaky behavior while running `TestSpanStatsFanOut` and `TestTenantSpanStats` under stress. Both tests have been updated to ensure the following behavior: - The tests make sure range splits occur before proceeding. - The tests will retry their assertions to give the new key-value pairs time to replicate. Additionally, `NewTestTenantHelper` was updated to accept a parameter for the number of nodes in the test host cluster. `TestTenantSpanStats` now uses a 3-node cluster to test a real fan-out. Resolves #99770 Resolves #99559 Epic:none Release note: None
pkg/ccl/serverccl/statusccl/statusccl_test.TestTenantStatusAPI failed with artifacts on release-23.1 @ 3551dc089ac3efcb3772df2109164dcb01e79d8f:
Parameters:
TAGS=bazel,gss,deadlock
Help
See also: How To Investigate a Go Test Failure (internal)
Same failure on other branches
This test on roachdash | Improve this report!
Jira issue: CRDB-26064
The text was updated successfully, but these errors were encountered: