Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

release-23.1: roachtest: bump split boundaries to prevent flakes #104107

Merged
merged 1 commit into from
May 30, 2023
Merged

release-23.1: roachtest: bump split boundaries to prevent flakes #104107

merged 1 commit into from
May 30, 2023

Conversation

blathers-crl[bot]
Copy link

@blathers-crl blathers-crl bot commented May 30, 2023 •
edited by kvoli
Loading

Backport 1/1 commits from #104084 on behalf of @kvoli.

/cc @cockroachdb/release

The load based splitting behavior was changed in #103690 to always find a real key to split at, rather than use sampled response spans as split points. This behavior change affected the number of splits in split/load roachtests.

Update the min and max boundaries for various split/load roachtests to conform to the new expected behavior.

See #103872 for updated split distribution over 190 test runs.

Fixes: #103691
Fixes: #103935
Resolves: #103872

Release note: None

Release justification: Test only change, deflake.

@kvoli
roachtest: bump split boundaries to prevent flakes
9e9042b 
The load based splitting behavior was changed in #103690 to always find
a real key to split at, rather than use sampled response spans as split
points. This behavior change affected the number of splits in
`split/load` roachtests.

Update the min and max boundaries for various `split/load` roachtests to
conform to the new expected behavior.

Fixes: #103691
Fixes: #103935
Resolves: #103872

Release note: None
@blathers-crl blathers-crl bot requested a review from a team as a code owner May 30, 2023 19:23
@blathers-crl blathers-crl bot force-pushed the blathers/backport-release-23.1-104084 branch from ce0101e to 4d9f9cb Compare May 30, 2023 19:23
@blathers-crl blathers-crl bot requested review from smg260 and renatolabs and removed request for a team May 30, 2023 19:23
@blathers-crl blathers-crl bot added blathers-backport This is a backport that Blathers created automatically. O-robot Originated from a bot. labels May 30, 2023
@blathers-crl blathers-crl bot force-pushed the blathers/backport-release-23.1-104084 branch from c405c82 to 9e9042b Compare May 30, 2023 19:23
@blathers-crl
Copy link
Author

blathers-crl bot commented May 30, 2023 •
edited by kvoli
Loading

Thanks for opening a backport.

Please check the backport criteria before merging:

  • Patches should only be created for serious issues or test-only changes.
  • Patches should not break backwards-compatibility.
  • Patches should change as little code as possible.
  • Patches should not change on-disk formats or node communication protocols.
  • Patches should not add new functionality.
  • Patches must not add, edit, or otherwise modify cluster versions; or add version gates.
If some of the basic criteria cannot be satisfied, ensure that the exceptional criteria are satisfied within.
  • There is a high priority need for the functionality that cannot wait until the next release and is difficult to address in another way.
  • The new functionality is additive-only and only runs for clusters which have specifically “opted in” to it (e.g. by a cluster setting).
  • New code is protected by a conditional check that is trivial to verify and ensures that it only runs for opt-in clusters.
  • The PM and TL on the team that owns the changed code have signed off that the change obeys the above rules.

Add a brief release justification to the body of your PR to justify this backport.

Some other things to consider:

  • What did we do to ensure that a user that doesn’t know & care about this backport, has no idea that it happened?
  • Will this work in a cluster of mixed patch versions? Did we test that?
  • If a user upgrades a patch version, uses this feature, and then downgrades, what happens?

@blathers-crl blathers-crl bot requested a review from tbg May 30, 2023 19:23
@cockroach-teamcity
Copy link
Member

This change is Reviewable

@kvoli
Copy link
Collaborator

kvoli commented May 30, 2023

TYFTR

@kvoli kvoli merged commit bfec830 into release-23.1 May 30, 2023
@kvoli kvoli deleted the blathers/backport-release-23.1-104084 branch May 30, 2023 20:25
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@tbg tbg tbg approved these changes

@smg260 smg260 Awaiting requested review from smg260 smg260 is a code owner automatically assigned from cockroachdb/test-eng

@renatolabs renatolabs Awaiting requested review from renatolabs renatolabs is a code owner automatically assigned from cockroachdb/test-eng

Assignees

@kvoli kvoli

Labels
blathers-backport This is a backport that Blathers created automatically. O-robot Originated from a bot.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@cockroach-teamcity @kvoli @tbg