Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

roachtest: splits/load/ycsb/b/nodes=3/obj=cpu failed #103935

Closed
cockroach-teamcity opened this issue May 26, 2023 · 1 comment · Fixed by #104084
Closed

roachtest: splits/load/ycsb/b/nodes=3/obj=cpu failed #103935

cockroach-teamcity opened this issue May 26, 2023 · 1 comment · Fixed by #104084
Assignees
@kvoli
Labels
A-testing Testing tools and infrastructure branch-release-23.1 Used to mark GA and release blockers, technical advisories, and bugs for 23.1 C-bug Code not up to spec/doc, specs & docs deemed correct. Solution expected to change code/behavior. C-test-failure Broken test (automatically or manually discovered). O-roachtest O-robot Originated from a bot. T-kv KV Team
Milestone
23.1

Comments

@cockroach-teamcity
Copy link
Member

cockroach-teamcity commented May 26, 2023 •
edited by cockroach-jira-scripts
Loading

roachtest.splits/load/ycsb/b/nodes=3/obj=cpu failed with artifacts on release-23.1 @ ac03080b01fd57dcaf6a3eeaa6686751a6094fa2:

test artifacts and logs in: /artifacts/splits/load/ycsb/b/nodes=3/obj=cpu/run_1
(monitor.go:127).Wait: monitor failure: monitor task failed: 17 splits, expected between 18 and 28 splits (ranges 19 initial 2)

Parameters: ROACHTEST_cloud=gce , ROACHTEST_cpu=4 , ROACHTEST_encrypted=false , ROACHTEST_ssd=0

Help

See: roachtest README

See: How To Investigate (internal)

/cc @cockroachdb/kv-triage

This test on roachdash | Improve this report!

Jira issue: CRDB-28263
@cockroach-teamcity cockroach-teamcity added branch-release-23.1 Used to mark GA and release blockers, technical advisories, and bugs for 23.1 C-test-failure Broken test (automatically or manually discovered). O-roachtest O-robot Originated from a bot. release-blocker Indicates a release-blocker. Use with branch-release-2x.x label to denote which branch is blocked. T-kv KV Team labels May 26, 2023
@cockroach-teamcity cockroach-teamcity added this to the 23.1 milestone May 26, 2023
@tbg tbg mentioned this issue May 26, 2023
Closed
@tbg
Copy link
Member

tbg commented May 26, 2023 •
edited
Loading

Suspecting this has to do with #103690, which merged yesterday. cc @kvoli

Adding C-bug to get it out of the triage queue, but feel free to add A-testing if we end up considering this a bug in the test.

@tbg tbg added C-bug Code not up to spec/doc, specs & docs deemed correct. Solution expected to change code/behavior. and removed release-blocker Indicates a release-blocker. Use with branch-release-2x.x label to denote which branch is blocked. labels May 26, 2023
@kvoli kvoli added A-testing Testing tools and infrastructure and removed C-bug Code not up to spec/doc, specs & docs deemed correct. Solution expected to change code/behavior. labels May 26, 2023
@tbg tbg added the C-bug Code not up to spec/doc, specs & docs deemed correct. Solution expected to change code/behavior. label May 30, 2023
@kvoli kvoli mentioned this issue May 30, 2023
Merged
@kvoli kvoli self-assigned this May 30, 2023
craig bot pushed a commit that referenced this issue May 30, 2023
@andyyang890 @kvoli
Merge #103985 #104084
b5feced 
103985: roachtest: update activerecord adapter version r=rafiss a=andyyang890

This patch updates the version of the CockroachDB activerecord adapter
used for testing to v7.0.2.

Informs #97283
Informs #99620

Release note: None

104084: roachtest: bump split boundaries to prevent flakes r=tbg a=kvoli

The load based splitting behavior was changed in #103690 to always find a real key to split at, rather than use sampled response spans as split points. This behavior change affected the number of splits in `split/load` roachtests.

Update the min and max boundaries for various `split/load` roachtests to conform to the new expected behavior.

See #103872 for updated split distribution over 190 test runs.

Fixes: #103691
Fixes: #103935
Resolves: #103872

Release note: None

Co-authored-by: Andy Yang <[email protected]>
Co-authored-by: Austen McClernon <[email protected]>
@craig craig bot closed this as completed in 64f5db9 May 30, 2023
@blathers-crl blathers-crl bot mentioned this issue May 30, 2023
Merged
blathers-crl bot pushed a commit that referenced this issue May 30, 2023
@kvoli
roachtest: bump split boundaries to prevent flakes
9e9042b 
The load based splitting behavior was changed in #103690 to always find
a real key to split at, rather than use sampled response spans as split
points. This behavior change affected the number of splits in
`split/load` roachtests.

Update the min and max boundaries for various `split/load` roachtests to
conform to the new expected behavior.

Fixes: #103691
Fixes: #103935
Resolves: #103872

Release note: None
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@kvoli kvoli

Labels
A-testing Testing tools and infrastructure branch-release-23.1 Used to mark GA and release blockers, technical advisories, and bugs for 23.1 C-bug Code not up to spec/doc, specs & docs deemed correct. Solution expected to change code/behavior. C-test-failure Broken test (automatically or manually discovered). O-roachtest O-robot Originated from a bot. T-kv KV Team
Projects
None yet
Milestone
23.1
Development

Successfully merging a pull request may close this issue.

roachtest: bump split boundaries to prevent flakes kvoli/cockroach
3 participants
@tbg @cockroach-teamcity @kvoli