workload/schemachanger: version gate JSON indexes in workload #103679
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
This change is |
fqazi
force-pushed
the
fixJsonIndexColumns
branch
from
094584c to
276e688
Compare
fqazi
changed the title
fqazi
force-pushed
the
fixJsonIndexColumns
branch
from
276e688 to
6590583
Compare
fqazi
requested review from
herkolategan,
renatolabs and
a team
and removed request for
a team
rafiss
requested changes
May 24, 2023
fqazi
force-pushed
the
fixJsonIndexColumns
branch
3 times, most recently
from
0101790 to
52c839c
Compare
fqazi
force-pushed
the
fixJsonIndexColumns
branch
3 times, most recently
from
6614581 to
0ea367e
Compare
rafiss
approved these changes
May 24, 2023
Previously, the randomized schema changer workload could try to use JSON indexes in a mixed version state where not all nodes supported them. This could lead to errors during the randomized workload. To address this, this patch version gates CREATE INDEX statements to avoid JSON indexes until the active version is high enough. Fixes: cockroachdb#103452 Release note: None
fqazi
force-pushed
the
fixJsonIndexColumns
branch
from
0ea367e to
bfc1c5b
Compare
|
@rafiss TFTR! bors r+ |
|
This PR was included in a batch that timed out, it will be automatically retried |
|
Build succeeded: |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Previously, the randomized schema changer workload could try to use JSON indexes in a mixed version state where not all nodes supported them. This could lead to errors during the randomized workload. To address this, this patch version gates CREATE INDEX statements to avoid JSON indexes until the active version is high enough.
Fixes: #103452
Fixes #103758
Release note: None