Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

roachtest: acceptance/mixed version flaked on master #103452

Closed
msbutler opened this issue May 16, 2023 · 4 comments · Fixed by #103679
Closed

roachtest: acceptance/mixed version flaked on master #103452

msbutler opened this issue May 16, 2023 · 4 comments · Fixed by #103679
Assignees
@fqazi
Labels
C-test-failure Broken test (automatically or manually discovered). T-testeng TestEng Team

Comments

@msbutler
Copy link
Collaborator

msbutler commented May 16, 2023 •
edited by cockroach-jira-scripts
Loading

See CI flake here. Error that bubbled up:

(mixedversion.go:399).Run: mixed-version test failure while running step 19 (run "run backup"): pq: relation "table2" (184): PARTITION table2_part0: unimplemented: unable to encode JSON as a table key

Jira issue: CRDB-28007
@msbutler msbutler added C-test-failure Broken test (automatically or manually discovered). T-testeng TestEng Team labels May 16, 2023
@blathers-crl
Copy link

blathers-crl bot commented May 16, 2023

cc @cockroachdb/test-eng

@renatolabs
Copy link
Contributor

It seems to me that the schemachange workload is generating schemas that should not be valid in mixed-version (specifically, that partition involving a JSONB column).

@fqazi could you take a look?

Also, maybe a noob question, but why is the backup step failing, and not the corresponding CREATE TABLE?

@fqazi
Copy link
Collaborator

fqazi commented May 17, 2023

@renatolabs Let me a dig a bit

@fqazi
Copy link
Collaborator

fqazi commented May 17, 2023

I think #101932 will also a bit beneficial here, but I don't think it will eliminate this

@fqazi fqazi self-assigned this May 19, 2023
@fqazi fqazi mentioned this issue May 19, 2023
Merged
fqazi added a commit to fqazi/cockroach that referenced this issue May 19, 2023
@fqazi
workload/schemachanger: version gate JSON indexes in workload
6590583 
Previously, the randomized schema changer workload could try to
use JSON indexes in a mixed version state where not all nodes
supported them. This could lead to errors during the randomized
workload. To address this, this patch version gates CREATE INDEX
statements to avoid JSON indexes until the active version is high
enough.

Fixes: cockroachdb#103452
Release note: None
craig bot pushed a commit that referenced this issue May 24, 2023
@fqazi @raggar @sjbarag
Merge #103679 #103783 #103850
aaaae95 
103679: workload/schemachanger: version gate JSON indexes in workload r=fqazi a=fqazi

Previously, the randomized schema changer workload could try to use JSON indexes in a mixed version state where not all nodes supported them. This could lead to errors during the randomized workload. To address this, this patch version gates CREATE INDEX statements to avoid JSON indexes until the active version is high enough.

Fixes: #103452
Fixes #103758

Release note: None

103783: pkg/ccl/storageccl/engineccl: ensure encryption percentage does not e… r=RahulAggarwal1016 a=RahulAggarwal1016

ensure encryption percentage does not exceed 100%

package: pkg/ccl/storageccl/engineccl

Previously, the `TotalFiles` property from `GenEnvStats()` returned the
total number of files known to Pebble, however this results in encryption
percentages that are greater than 100%. The fix is to set TotalFiles to
be the maximum of the files known to Pebble and the files known by the
file registry. This applies to the `TotalBytes` property as well.

Fixes: #97874

Release note: None

103850: ui: remove unused karma and webpack-dashboard dependencies r=fantapop a=sjbarag

We haven't used karma for testing DB Console since the summer of 2022, but never removed the declared dependency. Ditto webpack-dashboard, which hasn't been used since May 2021.

Epic: none
Release note: None

Co-authored-by: Faizan Qazi <[email protected]>
Co-authored-by: Rahul Aggarwal <[email protected]>
Co-authored-by: Sean Barag <[email protected]>
@craig craig bot closed this as completed in bfc1c5b May 24, 2023
@herkolategan herkolategan mentioned this issue Jun 5, 2023
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@fqazi fqazi

Labels
C-test-failure Broken test (automatically or manually discovered). T-testeng TestEng Team
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

workload/schemachanger: version gate JSON indexes in workload fqazi/cockroach
3 participants
@fqazi @msbutler @renatolabs