Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

autoconfig: fix the start/completion marker prefix encoding #101161

Merged
merged 1 commit into from
Apr 10, 2023

Conversation

knz
Copy link
Contributor

@knz knz commented Apr 10, 2023

Fixes #101157.

In the previous PR in this area, while the PR was in-flux we changed the info key encoding. However, half of the marker API wasn't updated accordingly.

This patch fixes it.

Release note: None

In the previous PR in this area, while the PR was in-flux we changed
the info key encoding. However, half of the marker API wasn't updated
accordingly.

This patch fixes it.

Release note: None
@knz knz requested a review from adityamaru April 10, 2023 19:54
@knz knz requested a review from a team as a code owner April 10, 2023 19:54
@cockroach-teamcity
Copy link
Member

This change is Reviewable

@knz
Copy link
Contributor Author

knz commented Apr 10, 2023

bors r=adityamaru

@knz knz added the backport-23.1.x Flags PRs that need to be backported to 23.1 label Apr 10, 2023
@knz knz removed the backport-23.1.x Flags PRs that need to be backported to 23.1 label Apr 10, 2023
@craig
Copy link
Contributor

craig bot commented Apr 10, 2023

Build succeeded:

@craig craig bot merged commit dd237e6 into cockroachdb:master Apr 10, 2023
@knz knz deleted the 20231010-autoconfig-bug branch April 10, 2023 21:35
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

autoconfig: runaway runner due to bug in InfoKeyStartPrefix
3 participants