Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

autoconfig: runaway runner due to bug in InfoKeyStartPrefix #101157

Closed
knz opened this issue Apr 10, 2023 · 0 comments · Fixed by #101161
Closed

autoconfig: runaway runner due to bug in InfoKeyStartPrefix #101157

knz opened this issue Apr 10, 2023 · 0 comments · Fixed by #101161
Labels
branch-master Failures and bugs on the master branch. C-bug Code not up to spec/doc, specs & docs deemed correct. Solution expected to change code/behavior. GA-blocker

Comments

@knz
Copy link
Contributor

knz commented Apr 10, 2023 •
edited by cockroach-jira-scripts
Loading

After I rebased the autoconfig PR when the info_key column type was changed from bytes to string, I forgot to update InfoKeyStartPrefix. There was no unit test to catch it.

Epic: CRDB-23559

Jira issue: CRDB-26832
@knz knz added C-bug Code not up to spec/doc, specs & docs deemed correct. Solution expected to change code/behavior. branch-master Failures and bugs on the master branch. GA-blocker T-multitenant Issues owned by the multi-tenant virtual team labels Apr 10, 2023
@exalate-issue-sync exalate-issue-sync bot removed the T-multitenant Issues owned by the multi-tenant virtual team label Apr 10, 2023
@knz knz mentioned this issue Apr 10, 2023
Merged
@craig craig bot closed this as completed in dd237e6 Apr 10, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
branch-master Failures and bugs on the master branch. C-bug Code not up to spec/doc, specs & docs deemed correct. Solution expected to change code/behavior. GA-blocker
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

autoconfig: fix the start/completion marker prefix encoding knz/cockroach
1 participant
@knz