Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

backupccl: TestBackupRestoreDuringUserDefinedTypeChange panics within tenant #88381

Closed
msbutler opened this issue Sep 21, 2022 · 3 comments · Fixed by #88271
Closed

backupccl: TestBackupRestoreDuringUserDefinedTypeChange panics within tenant #88381

msbutler opened this issue Sep 21, 2022 · 3 comments · Fixed by #88271
Labels
A-disaster-recovery branch-release-22.2 Used to mark GA and release blockers, technical advisories, and bugs for 22.2 C-test-failure Broken test (automatically or manually discovered). stability-period-v22.2 T-sql-foundations SQL Foundations Team (formerly SQL Schema + SQL Sessions)

Comments

@msbutler
Copy link
Collaborator

msbutler commented Sep 21, 2022 •
edited
Loading

To reproduce, stress the test on top of #88271, with DisableTenantTestTenant set to false.

See test failure artifacts here.

Fresh build reveals more subtests hit the same panic: https://teamcity.cockroachdb.com/viewLog.html?buildId=6576285&buildTypeId=Cockroach_BazelEssentialCi

Jira issue: CRDB-19794
@msbutler msbutler added C-test-failure Broken test (automatically or manually discovered). T-disaster-recovery GA-blocker T-sql-schema-deprecated Use T-sql-foundations instead branch-release-22.2 Used to mark GA and release blockers, technical advisories, and bugs for 22.2 stability-period Intended to be worked on during a stability period. Use with the Milestone field to specify version. labels Sep 21, 2022
@blathers-crl
Copy link

blathers-crl bot commented Sep 21, 2022

cc @cockroachdb/disaster-recovery

@msbutler msbutler changed the title backupccl: TestBackupRestoreDuringUserDefinedTypeChange/AddInStatement-schema-only panics within tenant backupccl: TestBackupRestoreDuringUserDefinedTypeChange panics within tenant Sep 22, 2022
@stevendanna
Copy link
Collaborator

It looks to me like the panic here is actually a timeout. My suspicion here is that our testing hooks aren't property flowing through to the testing server so we are waiting forever on one of these channel selects.

@msbutler msbutler mentioned this issue Sep 26, 2022
Merged
@ajwerner
Copy link
Contributor

I'm taking this off the schema board.

msbutler added a commit to msbutler/cockroach that referenced this issue Sep 27, 2022
@msbutler
backupccl: allow backupRestoreTestSetup[Empty]WithParams to test with…
c321fef 
…in tenant

Previously, all backup unit tests that called backupRestoreTestSetupWithParams
and backupRestoreTestSetupEmptyWithParams were disabled to run within tenants,
signficantly decreasing test coverage.

This patch allows tests that call these helper methods to be probabilistically
run within tenants (including most data driven tests). This patch also manually
disables some of these tests to be run within tenants. Future work should
continue to enable bulk unit tests to run within tenants by default.

Fixes cockroachdb#88381, cockroachdb#88527, cockroachdb#88453, cockroachdb#88380
Release note: None
msbutler added a commit to msbutler/cockroach that referenced this issue Oct 14, 2022
@msbutler
backupccl: allow backupRestoreTestSetup[Empty]WithParams to test with…
81fc39c 
…in tenant

Previously, all backup unit tests that called backupRestoreTestSetupWithParams
and backupRestoreTestSetupEmptyWithParams were disabled to run within tenants,
signficantly decreasing test coverage.

This patch allows tests that call these helper methods to be probabilistically
run within tenants (including most data driven tests). This patch also manually
disables some of these tests to be run within tenants. Future work should
continue to enable bulk unit tests to run within tenants by default.

Fixes cockroachdb#88381, cockroachdb#88527, cockroachdb#88453, cockroachdb#88380
Release note: None
craig bot pushed a commit that referenced this issue Oct 19, 2022
@msbutler
Merge #88271
e711c31 
88271: backupccl: allow backupRestoreTestSetup[Empty]WithParams to test within a tenant r=adityamaru a=msbutler

Previously, all backup unit tests that called backupRestoreTestSetupWithParams
and backupRestoreTestSetupEmptyWithParams were disabled to run within tenants,
signficantly decreasing test coverage.

This patch allows tests that call these helper methods to be probabilistically
run within tenants (including most data driven tests). This patch also manually
disables some of these tests to be run within tenants. Future work should
continue to enable bulk unit tests to run within tenants by default.

Fixes #88381, #88527, #88453, #88380
Release note: None

Co-authored-by: Michael Butler <[email protected]>
@craig craig bot closed this as completed in fd7f48d Oct 19, 2022
@healthy-pod healthy-pod added T-sql-foundations SQL Foundations Team (formerly SQL Schema + SQL Sessions) and removed T-sql-schema-deprecated Use T-sql-foundations instead labels May 17, 2023
@exalate-issue-sync exalate-issue-sync bot added stability-period-v22.2 and removed stability-period Intended to be worked on during a stability period. Use with the Milestone field to specify version. labels May 23, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
A-disaster-recovery branch-release-22.2 Used to mark GA and release blockers, technical advisories, and bugs for 22.2 C-test-failure Broken test (automatically or manually discovered). stability-period-v22.2 T-sql-foundations SQL Foundations Team (formerly SQL Schema + SQL Sessions)
Projects
No open projects
Disaster Recovery Backlog
Archived in project
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

backupccl: allow backupRestoreTestSetup[Empty]WithParams to test within a tenant msbutler/cockroach
4 participants
@stevendanna @ajwerner @healthy-pod @msbutler