Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

backupccl: TestBackupRestoreTelemetryEvents panics when run within a tenant #88380

Closed
msbutler opened this issue Sep 21, 2022 · 3 comments
Closed
Assignees
Labels
A-disaster-recovery C-bug Code not up to spec/doc, specs & docs deemed correct. Solution expected to change code/behavior. C-test-failure Broken test (automatically or manually discovered). stability-period Intended to be worked on during a stability period. Use with the Milestone field to specify version. T-disaster-recovery

Comments

@msbutler
Copy link
Collaborator

msbutler commented Sep 21, 2022

To reproduce, stress the test on top of #88271, with DisableTenantTestTenant set to false.

See test failure artifacts here.

Jira issue: CRDB-19793

@msbutler msbutler added C-bug Code not up to spec/doc, specs & docs deemed correct. Solution expected to change code/behavior. T-disaster-recovery GA-blocker labels Sep 21, 2022
@blathers-crl
Copy link

blathers-crl bot commented Sep 21, 2022

cc @cockroachdb/disaster-recovery

@blathers-crl
Copy link

blathers-crl bot commented Sep 21, 2022

Hi @msbutler, please add branch-* labels to identify which branch(es) this release-blocker affects.

🦉 Hoot! I am a Blathers, a bot for CockroachDB. My owner is otan.

@msbutler msbutler added branch-release-22.2 Used to mark GA and release blockers, technical advisories, and bugs for 22.2 stability-period Intended to be worked on during a stability period. Use with the Milestone field to specify version. C-test-failure Broken test (automatically or manually discovered). and removed GA-blocker branch-release-22.2 Used to mark GA and release blockers, technical advisories, and bugs for 22.2 labels Sep 21, 2022
msbutler added a commit to msbutler/cockroach that referenced this issue Sep 27, 2022
…in tenant

Previously, all backup unit tests that called backupRestoreTestSetupWithParams
and backupRestoreTestSetupEmptyWithParams were disabled to run within tenants,
signficantly decreasing test coverage.

This patch allows tests that call these helper methods to be probabilistically
run within tenants (including most data driven tests). This patch also manually
disables some of these tests to be run within tenants. Future work should
continue to enable bulk unit tests to run within tenants by default.

Fixes cockroachdb#88381, cockroachdb#88527, cockroachdb#88453, cockroachdb#88380
Release note: None
msbutler added a commit to msbutler/cockroach that referenced this issue Oct 14, 2022
…in tenant

Previously, all backup unit tests that called backupRestoreTestSetupWithParams
and backupRestoreTestSetupEmptyWithParams were disabled to run within tenants,
signficantly decreasing test coverage.

This patch allows tests that call these helper methods to be probabilistically
run within tenants (including most data driven tests). This patch also manually
disables some of these tests to be run within tenants. Future work should
continue to enable bulk unit tests to run within tenants by default.

Fixes cockroachdb#88381, cockroachdb#88527, cockroachdb#88453, cockroachdb#88380
Release note: None
msbutler added a commit to msbutler/cockroach that referenced this issue Oct 19, 2022
…in tenant

Previously, all backup unit tests that called backupRestoreTestSetupWithParams
and backupRestoreTestSetupEmptyWithParams were disabled to run within tenants,
signficantly decreasing test coverage.

This patch allows tests that call these helper methods to be probabilistically
run within tenants (including most data driven tests). This patch also manually
disables some of these tests to be run within tenants. Future work should
continue to enable bulk unit tests to run within tenants by default.

Fixes cockroachdb#88381, cockroachdb#88527, cockroachdb#88453, cockroachdb#88380
Release note: None
craig bot pushed a commit that referenced this issue Oct 19, 2022
88271: backupccl: allow backupRestoreTestSetup[Empty]WithParams to test within a tenant r=adityamaru a=msbutler

Previously, all backup unit tests that called backupRestoreTestSetupWithParams
and backupRestoreTestSetupEmptyWithParams were disabled to run within tenants,
signficantly decreasing test coverage.

This patch allows tests that call these helper methods to be probabilistically
run within tenants (including most data driven tests). This patch also manually
disables some of these tests to be run within tenants. Future work should
continue to enable bulk unit tests to run within tenants by default.

Fixes #88381, #88527, #88453, #88380
Release note: None

Co-authored-by: Michael Butler <[email protected]>
@msbutler
Copy link
Collaborator Author

closed by #88271

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
A-disaster-recovery C-bug Code not up to spec/doc, specs & docs deemed correct. Solution expected to change code/behavior. C-test-failure Broken test (automatically or manually discovered). stability-period Intended to be worked on during a stability period. Use with the Milestone field to specify version. T-disaster-recovery
Projects
No open projects
Archived in project
Development

No branches or pull requests

1 participant