Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Relabel Custom date range to Custom time interval in time picker and update tooltips #84361

Closed
ghost opened this issue Jul 13, 2022 · 0 comments · Fixed by #84486
Closed

Relabel Custom date range to Custom time interval in time picker and update tooltips #84361

ghost opened this issue Jul 13, 2022 · 0 comments · Fixed by #84486
Assignees
@maryliag
Labels
A-sql-observability Related to observability of the SQL layer C-bug Code not up to spec/doc, specs & docs deemed correct. Solution expected to change code/behavior.

Comments

@ghost
Copy link

ghost commented Jul 13, 2022 •
edited by ghost
Loading

According to #83420 we prefer the term time interval instead of date range. Therefore the final option in the time picker should be relabeled to Custom time interval.

Screen Shot 2022-07-13 at 9 10 47 AM

Consider changing the previous and next tooltips from previous/next timeframe to previous/next time interval
Screen Shot 2022-07-13 at 9 45 09 AM

Add a tooltip to the Now button that is explanatory and doesn't repeat the button label.

Screen Shot 2022-07-13 at 9 46 15 AM

Jira issue: CRDB-17616
@ghost ghost added C-bug Code not up to spec/doc, specs & docs deemed correct. Solution expected to change code/behavior. A-sql-observability Related to observability of the SQL layer T-sql-observability labels Jul 13, 2022
@ghost ghost mentioned this issue Jul 13, 2022
Merged
@ghost ghost changed the title Relabel Custom date range to Custom time interval in time picker Relabel Custom date range to Custom time interval in time picker and update tooltips Jul 13, 2022
@maryliag maryliag self-assigned this Jul 15, 2022
@maryliag maryliag mentioned this issue Jul 15, 2022
Merged
@exalate-issue-sync exalate-issue-sync bot mentioned this issue Jul 15, 2022
Closed
craig bot pushed a commit that referenced this issue Jul 15, 2022
@jordanlewis @Xiang-Gu
@maryliag @msbutler
Merge #80305 #84303 #84436 #84486 #84507
a3d74c3 
80305: colfetcher: tiny optimization r=yuzefovich a=jordanlewis

I noticed the call to .Len() in this loop was showing up as 3% in the
profile Yahor created of the TPCH query. This is an easy fix.

Ideally we'd be able to microbenchmark this, so I filed #80302. 

Release note: None

84303: sql: `ALTER PRIMARY KEY` rewrites secondary index if new PK subsets old PK r=Xiang-Gu a=Xiang-Gu

Previously, during a `ALTER PRIMARY KEY`, if the new PK columns is a
subset of the old PK columns, we won't rewrite existing unique,
secondary index.

This was inadequate because the user might think this column is not used
anywhere and will want to drop it, which will unexpectedly drop the
dependent unique index.

Fixes: #84040

Release note (bug fix): This PR fixed a bug where, in a 
`ALTER PRIMARY KEY`, if the new PK columns is a 
subset of the old PK columns, we will not rewrite existing secondary
index, and hence those secondary indexes continue to have some of
the old PK columns in their `suffixColumns`.

But the user might, reasonably, think those columns are not used anymore
and proceed to drop them. The bug then caused those dependent secondary
indexes to be dropped, unexpectedly for the user.

84436: ccl: upgrade by-name sequence reference to by-ID during restore r=Xiang-Gu a=Xiang-Gu

In 20.2 and prior, sequences are referenced by-name. It was later
changed to reference-by-ID to enable things like
`ALTER SEQUENCE ... RENAME ...`.

But if a backup is taken in 20.2 and prior, and then the backup is
restored in a newer binary version (where sequence references should
be by-ID), we will need to also be able to upgrade those sequence
references from by-name to by-ID.

Release note: None

84486: ui: update usages of date range to time interval r=maryliag a=maryliag

This commit updates the labels previously saying "date range"
to "time interval".
This commit also removes an unnecessary tooltip on the "now"
button and fix its styling when disabled.

Fixes #84361
<img width="252" alt="Screen Shot 2022-07-15 at 9 58 39 AM" src="https://user-images.githubusercontent.com/1017486/179239746-b56b5df7-a001-4f5f-9aea-3578a948eccc.png">
<img width="189" alt="Screen Shot 2022-07-15 at 9 58 48 AM" src="https://user-images.githubusercontent.com/1017486/179239804-437e9951-04de-402b-b62b-7e013a715afb.png">
<img width="519" alt="Screen Shot 2022-07-15 at 10 00 49 AM" src="https://user-images.githubusercontent.com/1017486/179239870-d6f0d61e-f6ee-4e7f-83a1-f80fc1fa4db8.png">
<img width="447" alt="Screen Shot 2022-07-15 at 10 00 56 AM" src="https://user-images.githubusercontent.com/1017486/179239923-17a0408a-ff81-4e5a-94f3-7e5b26430bb9.png">


Release note (ui change): Update of labels from "date range" to
"time interval" on time picker (custom option, preset title, previous
and next arrows)

84507: Revert "storageccl: use NewPebbleIterator in restore data processor" r=erikgrinaker a=msbutler

This reverts commit 4d1f66e.

Release Note: none

Co-authored-by: Jordan Lewis <[email protected]>
Co-authored-by: Xiang Gu <[email protected]>
Co-authored-by: Marylia Gutierrez <[email protected]>
Co-authored-by: Michael Butler <[email protected]>
@craig craig bot closed this as completed in 0e3e735 Jul 15, 2022
blathers-crl bot pushed a commit that referenced this issue Jul 15, 2022
@maryliag
ui: update usages of date range to time interval
15d4fcb 
This commit updates the labels previously saying "date range"
to "time interval".
This commit also removes an unnecessary tooltip on the "now"
button and fix its styling when disabled.

Fixes #84361

Release note (ui change): Update of labels from "date range" to
"time interval" on time picker (custom option, preset title, previous
and next arrows)
@blathers-crl blathers-crl bot mentioned this issue Jul 15, 2022
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@maryliag maryliag

Labels
A-sql-observability Related to observability of the SQL layer C-bug Code not up to spec/doc, specs & docs deemed correct. Solution expected to change code/behavior.
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

ui: update usages of date range to time interval maryliag/cockroach
1 participant
@maryliag