Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

ccl: upgrade by-name sequence reference to by-ID during restore #84436

Conversation

Xiang-Gu
Copy link
Contributor

In 20.2 and prior, sequences are referenced by-name. It was later
changed to reference-by-ID to enable things like
ALTER SEQUENCE ... RENAME ....

But if a backup is taken in 20.2 and prior, and then the backup is
restored in a newer binary version (where sequence references should
be by-ID), we will need to also be able to upgrade those sequence
references from by-name to by-ID.

Release note: None

In 20.2 and prior, sequences are referenced by-name. It was later
changed to reference-by-ID to enable things like
`ALTER SEQUENCE ... RENAME ...`.

But if a backup is taken in 20.2 and prior, and then the backup is
restored in a newer binary version (where sequence references should
be by-ID), we will need to also be able to upgrade those sequence
references from by-name to by-ID.

Release note: None
@cockroach-teamcity
Copy link
Member

This change is Reviewable

@Xiang-Gu Xiang-Gu marked this pull request as ready for review July 14, 2022 19:17
@Xiang-Gu Xiang-Gu requested review from a team and rhu713 July 14, 2022 19:17
@Xiang-Gu
Copy link
Contributor Author

Xiang-Gu commented Jul 14, 2022

This PR was previously merged into master and later reverted because of dependency violations. With @ajwerner's recent PR, this is ready to be merged back to master again.

Copy link
Contributor

@postamar postamar left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM assuming nothing fundamentally changed.

@Xiang-Gu
Copy link
Contributor Author

TFTR!

bors r+

@craig craig bot merged commit a3d74c3 into cockroachdb:master Jul 15, 2022
@craig
Copy link
Contributor

craig bot commented Jul 15, 2022

Build succeeded:

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants