-
Notifications
You must be signed in to change notification settings - Fork 3.8k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
sql: add new builtins to save and restore a session #68464
Comments
Rudimentary research:
|
ah, sequences are already serialisable. |
What guarantees do we have about migrating settings between different version of CockroachDB? |
ah wait, there's this thing for sequences: cockroach/pkg/sql/sessiondata/session_data.go Lines 268 to 270 in 50ef2fc
|
68525: sql: convert LocalOnlySessionData to protobuf r=rafiss a=otan See individual commits for details. Refs: #68464 Co-authored-by: Oliver Tan <[email protected]>
To allow SQL pods to scale down and back up, without user impact, we should add two new builtins:
This state can just be returned directly to the caller (in this case
sqlproxy
) in some encoded form.sqlproxy
is in charge of managing this encoded state.The initial implementation of these builtins only needs to include the values of all session variables in the state.
Behavior:
SHOW
ing each session var, and thenSET
ing them all later.)Out of scope for this issue:
Epic CRDB-1464
The text was updated successfully, but these errors were encountered: