-
Notifications
You must be signed in to change notification settings - Fork 3.8k
Commit
This commit does not belong to any branch on this repository, and may belong to a fork outside of the repository.
68792: builtins: implement session serialization and deserialization r=rafiss a=otan See individual commits for details. Resolves #68464 Co-authored-by: Oliver Tan <[email protected]>
- Loading branch information
Showing
21 changed files
with
1,357 additions
and
149 deletions.
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,135 @@ | ||
| // Copyright 2021 The Cockroach Authors. | ||
| // | ||
| // Use of this software is governed by the Business Source License | ||
| // included in the file licenses/BSL.txt. | ||
| // | ||
| // As of the Change Date specified in that file, in accordance with | ||
| // the Business Source License, use of this software will be governed | ||
| // by the Apache License, Version 2.0, included in the file | ||
| // licenses/APL.txt. | ||
|
|
||
| package sql_test | ||
|
|
||
| import ( | ||
| "context" | ||
| gosql "database/sql" | ||
| "fmt" | ||
| "strings" | ||
| "testing" | ||
|
|
||
| "github.com/cockroachdb/cockroach/pkg/base" | ||
| "github.com/cockroachdb/cockroach/pkg/testutils/serverutils" | ||
| "github.com/cockroachdb/cockroach/pkg/testutils/sqlutils" | ||
| "github.com/cockroachdb/cockroach/pkg/testutils/testcluster" | ||
| "github.com/cockroachdb/cockroach/pkg/util/leaktest" | ||
| "github.com/cockroachdb/cockroach/pkg/util/log" | ||
| "github.com/cockroachdb/datadriven" | ||
| "github.com/stretchr/testify/require" | ||
| ) | ||
|
|
||
| // TestSessionMigration tests migrating a session as a data driven test. | ||
| // It supports the following directives: | ||
| // * reset: resets the connection. | ||
| // * exec: executes a SQL command | ||
| // * query: executes a SQL command and returns the output | ||
| // * dump_vars: dumps variables into a variable called with the given input. | ||
| // * compare_vars: compares two dumped variables. | ||
| func TestSessionMigration(t *testing.T) { | ||
| defer leaktest.AfterTest(t)() | ||
| defer log.Scope(t).Close(t) | ||
|
|
||
| ctx := context.Background() | ||
| datadriven.Walk(t, "testdata/session_migration", func(t *testing.T, path string) { | ||
| tc := testcluster.StartTestCluster(t, 1, base.TestClusterArgs{}) | ||
| defer tc.Stopper().Stop(ctx) | ||
|
|
||
| openConnFunc := func() *gosql.DB { | ||
| return serverutils.OpenDBConn( | ||
| t, | ||
| tc.Server(0).ServingSQLAddr(), | ||
| "defaultdb", /* database */ | ||
| false, /* insecure */ | ||
| tc.Server(0).Stopper(), | ||
| ) | ||
| } | ||
| dbConn := openConnFunc() | ||
| defer func() { | ||
| _ = dbConn.Close() | ||
| }() | ||
|
|
||
| vars := make(map[string]string) | ||
| datadriven.RunTest(t, path, func(t *testing.T, d *datadriven.TestData) string { | ||
| getQuery := func() string { | ||
| q := d.Input | ||
| for k, v := range vars { | ||
| q = strings.ReplaceAll(q, k, v) | ||
| } | ||
| return q | ||
| } | ||
| switch d.Cmd { | ||
| case "reset": | ||
| require.NoError(t, dbConn.Close()) | ||
| dbConn = openConnFunc() | ||
| return "" | ||
| case "exec": | ||
| _, err := dbConn.Exec(getQuery()) | ||
| if err != nil { | ||
| return err.Error() | ||
| } | ||
| return "" | ||
| case "dump_vars": | ||
| require.NotEmpty(t, d.Input, "expected table name") | ||
| _, err := dbConn.Exec(fmt.Sprintf("CREATE TABLE %s AS SELECT * FROM [SHOW ALL]", d.Input)) | ||
| require.NoError(t, err) | ||
| return "" | ||
| case "compare_vars": | ||
| tables := strings.Split(d.Input, "\n") | ||
| require.Len(t, tables, 2, "require 2 tables to compare against") | ||
|
|
||
| q := `SELECT dump.variable, dump.value, dump2.variable, dump2.value | ||
| FROM dump | ||
| FULL OUTER JOIN dump2 | ||
| ON ( dump.variable = dump2.variable ) | ||
| WHERE dump.variable IS NULL OR dump2.variable IS NULL OR dump.variable != dump2.variable` | ||
| for _, repl := range []struct { | ||
| from string | ||
| to string | ||
| }{ | ||
| {"dump2", tables[1]}, | ||
| {"dump", tables[0]}, | ||
| } { | ||
| q = strings.ReplaceAll(q, repl.from, repl.to) | ||
| } | ||
| rows, err := dbConn.Query(q) | ||
| require.NoError(t, err) | ||
| ret, err := sqlutils.RowsToDataDrivenOutput(rows) | ||
| require.NoError(t, err) | ||
| return ret | ||
| case "query": | ||
| q := d.Input | ||
| for k, v := range vars { | ||
| q = strings.ReplaceAll(q, k, v) | ||
| } | ||
| rows, err := dbConn.Query(getQuery()) | ||
| if err != nil { | ||
| return err.Error() | ||
| } | ||
| ret, err := sqlutils.RowsToDataDrivenOutput(rows) | ||
| require.NoError(t, err) | ||
| return ret | ||
| case "let": | ||
| row := dbConn.QueryRow(getQuery()) | ||
| var v string | ||
| require.NoError(t, row.Err()) | ||
| require.NoError(t, row.Scan(&v)) | ||
| require.Len(t, d.CmdArgs, 1, "only one argument permitted for let") | ||
| for _, arg := range d.CmdArgs { | ||
| vars[arg.Key] = v | ||
| } | ||
| return "" | ||
| } | ||
| t.Fatalf("unknown command: %s", d.Cmd) | ||
| return "unexpected" | ||
| }) | ||
| }) | ||
| } |
Oops, something went wrong.