Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

sql: TestCancelQueryPermissions failed #53791

Closed
cockroach-teamcity opened this issue Sep 1, 2020 · 0 comments · Fixed by #62132
Closed

sql: TestCancelQueryPermissions failed #53791

cockroach-teamcity opened this issue Sep 1, 2020 · 0 comments · Fixed by #62132
Assignees
@solongordon
Labels
branch-master Failures and bugs on the master branch. C-test-failure Broken test (automatically or manually discovered). O-robot Originated from a bot.
Milestone
20.2

Comments

@cockroach-teamcity
Copy link
Member

(sql).TestCancelQueryPermissions failed on master@fe3d024bb0b778e98d53be3a2aac7ffffd128195:


Previous write at 0x00c029be3318 by goroutine 2240:
  github.com/cockroachdb/cockroach/pkg/sql.(*connExecutor).txnStateTransitionsApplyWrapper()
      /go/src/github.com/cockroachdb/cockroach/pkg/sql/conn_executor.go:2214 +0x68a
  github.com/cockroachdb/cockroach/pkg/sql.(*connExecutor).execCmd()
      /go/src/github.com/cockroachdb/cockroach/pkg/sql/conn_executor.go:1571 +0xd1a
  github.com/cockroachdb/cockroach/pkg/sql.(*connExecutor).run()
      /go/src/github.com/cockroachdb/cockroach/pkg/sql/conn_executor.go:1377 +0x486
  github.com/cockroachdb/cockroach/pkg/sql.(*InternalExecutor).initConnEx.func1()
      /go/src/github.com/cockroachdb/cockroach/pkg/sql/internal.go:175 +0x8e

Goroutine 3506 (running) created at:
  google.golang.org/grpc.(*Server).serveStreams.func1()
      /go/src/github.com/cockroachdb/cockroach/vendor/google.golang.org/grpc/server.go:744 +0xb8
  google.golang.org/grpc/internal/transport.(*http2Server).operateHeaders()
      /go/src/github.com/cockroachdb/cockroach/vendor/google.golang.org/grpc/internal/transport/http2_server.go:442 +0x16a6
  google.golang.org/grpc/internal/transport.(*http2Server).HandleStreams()
      /go/src/github.com/cockroachdb/cockroach/vendor/google.golang.org/grpc/internal/transport/http2_server.go:483 +0x459
  google.golang.org/grpc.(*Server).serveStreams()
      /go/src/github.com/cockroachdb/cockroach/vendor/google.golang.org/grpc/server.go:742 +0x19a
  google.golang.org/grpc.(*Server).handleRawConn.func1()
      /go/src/github.com/cockroachdb/cockroach/vendor/google.golang.org/grpc/server.go:703 +0x4c

Goroutine 2240 (running) created at:
  github.com/cockroachdb/cockroach/pkg/sql.(*InternalExecutor).initConnEx()
      /go/src/github.com/cockroachdb/cockroach/pkg/sql/internal.go:174 +0x595
  github.com/cockroachdb/cockroach/pkg/sql.(*InternalExecutor).execInternal()
      /go/src/github.com/cockroachdb/cockroach/pkg/sql/internal.go:446 +0x7f4
  github.com/cockroachdb/cockroach/pkg/sql.(*InternalExecutor).queryInternal()
      /go/src/github.com/cockroachdb/cockroach/pkg/sql/internal.go:241 +0x14f
  github.com/cockroachdb/cockroach/pkg/sql.(*InternalExecutor).QueryEx()
      /go/src/github.com/cockroachdb/cockroach/pkg/sql/internal.go:216 +0x14f
  github.com/cockroachdb/cockroach/pkg/sql.(*InternalExecutor).QueryRowEx()
      /go/src/github.com/cockroachdb/cockroach/pkg/sql/internal.go:271 +0x14f
  github.com/cockroachdb/cockroach/pkg/sql.retrieveUserAndPassword.func3()
      /go/src/github.com/cockroachdb/cockroach/pkg/sql/user.go:114 +0x1ce
  github.com/cockroachdb/cockroach/pkg/util/contextutil.RunWithTimeout()
      /go/src/github.com/cockroachdb/cockroach/pkg/util/contextutil/context.go:135 +0xdd
  github.com/cockroachdb/cockroach/pkg/sql.retrieveUserAndPassword.func2()
      /go/src/github.com/cockroachdb/cockroach/pkg/sql/user.go:106 +0x76
  github.com/cockroachdb/cockroach/pkg/sql.retrieveUserAndPassword()
      /go/src/github.com/cockroachdb/cockroach/pkg/sql/user.go:111 +0x39d
  github.com/cockroachdb/cockroach/pkg/sql.GetUserHashedPassword()
      /go/src/github.com/cockroachdb/cockroach/pkg/sql/user.go:84 +0x21b
  github.com/cockroachdb/cockroach/pkg/sql/pgwire.(*conn).handleAuthentication()
      /go/src/github.com/cockroachdb/cockroach/pkg/sql/pgwire/auth.go:86 +0xd5
  github.com/cockroachdb/cockroach/pkg/sql/pgwire.(*conn).processCommandsAsync.func1()
      /go/src/github.com/cockroachdb/cockroach/pkg/sql/pgwire/conn.go:560 +0x21e
==================
FAIL	github.com/cockroachdb/cockroach/pkg/sql	1066.142s
More

Parameters:

  • GOFLAGS=-json
make stressrace TESTS=TestCancelQueryPermissions PKG=./pkg/sql TESTTIMEOUT=5m STRESSFLAGS='-timeout 5m' 2>&1

See this test on roachdash
powered by pkg/cmd/internal/issues
@cockroach-teamcity cockroach-teamcity added branch-master Failures and bugs on the master branch. C-test-failure Broken test (automatically or manually discovered). O-robot Originated from a bot. labels Sep 1, 2020
@cockroach-teamcity cockroach-teamcity added this to the 20.2 milestone Sep 1, 2020
solongordon added a commit to solongordon/cockroach that referenced this issue Sep 1, 2020
@solongordon
sql: skip TestCancelQueryPermissions
1bc8d91 
This test is exposing more data races. Skipping until we can fix them.

Refs: cockroachdb#53791

Release justification: non-production code changes

Release note: None
@solongordon solongordon mentioned this issue Sep 1, 2020
Merged
craig bot pushed a commit that referenced this issue Sep 1, 2020
@andreimatei @otan
@adityamaru @mgartner @solongordon
Merge #53705 #53721 #53778 #53785 #53793
a30e3cd 
53705: kvclient: improve logging of slow RPCs in DistSender r=andreimatei a=andreimatei

Release justification: small change improving logging, hoping to help
debug #53197.

This patch moves the logging that the DistSender does when it detects an
RPC that is slow such that it kicks in in more cases:
1) if the RPC was successful (but slow)
2) if the lower layer in the DistSender failed to contact any replica
   and returned a sendError{}. In this case the range descriptor will be
   refreshed and the RPC will be retried, similar to the case in which a
   replica returned RangeKeyMismatchError. The RKME case was already
   covered by the logging, but the sendError case wasn't.

Touches #53197

Release note: None

53721: geo: rebrand geospatial to spatial with minor refactors r=sumeerbhola a=otan

* Rename geospatial to spatial (for outwards facing docs).
* Replace all (args[d].(*tree.DType)) to tree.MustBeDType(args[d])
* Add tests to ensure all geo builtin info has a capital letter and
  full stop.

Release justification: low risk update to new functionality

Release note: None



53778: backupccl: fixes cluster backup error string r=pbardea,dt a=adityamaru

Fixes: #52018

Release justification: low risk, high benefit changes to existing functionality

53785: opt: remove xfunc references and clean up EnsureKey r=RaduBerinde a=mgartner

#### norm: clean up EnsureKey decorrelation function

This commit replaces a single-case type switch statement in EnsureKey
with an `if` with a type assertion. It also adds clariying comments.

Release justification: This is a low-risk change to new and minor
changes to existing functionality.

Release note: None

#### opt: fix comment in xform custom_funcs.go

This commit removes references to the non-existent `xfunc` package.

Release justification: This is a non-production code-change.

Release note: None


53793: sql: skip TestCancelQueryPermissions r=solongordon a=solongordon

This test is exposing more data races. Skipping until we can fix them.

Refs: #53791

Release justification: non-production code changes

Release note: None

Co-authored-by: Andrei Matei <[email protected]>
Co-authored-by: Oliver Tan <[email protected]>
Co-authored-by: Aditya Maru <[email protected]>
Co-authored-by: Marcus Gartner <[email protected]>
Co-authored-by: Solon Gordon <[email protected]>
@rafiss rafiss mentioned this issue Mar 17, 2021
Merged
@craig craig bot closed this as completed in f57f911 Mar 17, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@solongordon solongordon

Labels
branch-master Failures and bugs on the master branch. C-test-failure Broken test (automatically or manually discovered). O-robot Originated from a bot.
Projects
None yet
Milestone
20.2
Development

Successfully merging a pull request may close this issue.

sql: unskip TestCancelQueryPermissions rafiss/cockroach
2 participants
@solongordon @cockroach-teamcity