geo: rebrand geospatial to spatial with minor refactors #53721
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
This change is |
otan
force-pushed
the
rebrand_geo
branch
4 times, most recently
from
5afb304 to
325ad66
Compare
sumeerbhola
approved these changes
Sep 1, 2020
There was a problem hiding this comment.
Reviewed 11 of 11 files at r1.
Reviewable status:complete! 1 of 0 LGTMs obtained (waiting on @otan)
pkg/sql/sem/builtins/geo_builtins.go, line 51 at r1 (raw file):
const usesSpheroidMessage = " Uses a spheroid to perform the operation." const spheroidDistanceMessage = `"\n\nWhen operating on a spheroid, this function will use the sphere to calculate ` + `the closest two points using a sphere. The spheroid distance between these two points is calculated using GeographicLib. ` +
I think we can end the sentence at "... closest two points." since it already says "will use the sphere" earlier in the sentence.
* Rename geospatial to spatial (for outwards facing docs). * Replace all (args[d].(*tree.DType)) to tree.MustBeDType(args[d]) * Add tests to ensure all geo builtin info has a capital letter and full stop. Release justification: low risk update to new functionality Release note (cli change): The `--geo-libs` flag introduced in v20.2-alphas is renamed to `--spatial-libs`.
|
bors r=sumeerbhola |
|
Build succeeded: |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
full stop.
Release justification: low risk update to new functionality
Release note: None