-
Notifications
You must be signed in to change notification settings - Fork 3.8k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
sql: support pgwire query cancellation #41335
Comments
@solongordon if this is relatively easy i'd be interested in picking it up because its used in part of the solution for #52240 and seems generally useful behavior for our drivers to posses. |
See #34520 for the latest attempt at implementing this. Eng has not really reached a consensus on how to do this. But I'm still hopeful! Knowing that there's a product motivation for working on it could make it easier to drive consensus. Also, I believe that we collect telemetry on how often a Cancel message is received. Not sure where to find it, but if anyone knows, I'd be curious to see the stats. |
It's the top unimplemented feature: https://cockroachlabs.looker.com/looks/47 We should prioritize this particularly if we have some prior art to draw upon. |
Idea here on how to translate with the proxy #67501 (comment) |
75870: rfc: pgwire-compatible query cancellation r=otan,knz a=rafiss refs #41335 Release note: None 76007: physicalplan: add support for multi-stage execution of regr_avgx, regr_avgy, regr_intercept, regr_r2, and regr_slope aggregate functions. r=yuzefovich a=mneverov physicalplan: add support for multi-stage execution of regr_avgx, regr_avgy, regr_intercept, regr_r2, and regr_slope aggregate functions. See #58347. Release note (performance improvement): regr_avgx, regr_avgy, regr_intercept, regr_r2, and regr_slope aggregate functions are now evaluated more efficiently in a distributed setting 76115: sql: use 16 as default bucket count for hash index r=chengxiong-ruan a=chengxiong-ruan for some reason I forgot to modify it in my previous pr :( Release note (sql change): 16 is used as the default bucket count for hash sharded index. 76262: server: remove DeprecateBaseEncryptionRegistry r=jbowens a=jbowens Remove the migration server DeprecateBaseEncryptionRegistry RPC. It was used for the migration of the encryption-at-rest registry format in 21.2 and is no longer relevant. Missed this in #74314. Release note: None Co-authored-by: Rafi Shamim <[email protected]> Co-authored-by: Max Neverov <[email protected]> Co-authored-by: Chengxiong Ruan <[email protected]> Co-authored-by: Jackson Owens <[email protected]>
Postgres docs describe how
BackendKeyData
is initialized by the DB on startup and sent to the client so it can be used for cancellation requests later.https://www.postgresql.org/docs/12/protocol-flow.html
CockroachDB has a separate cancel query syntax. For increased compatibility, we should support the Postgres version too.
There have been other attempts at doing this in the past, but they had some issues.
See #13009 #13191 #17003 #34520
Epic CRDB-7644
The text was updated successfully, but these errors were encountered: