Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

sql: use 16 as default bucket count for hash index #76115

Merged

Conversation

chengxiong-ruan
Copy link
Contributor

@chengxiong-ruan chengxiong-ruan commented Feb 5, 2022

for some reason I forgot to modify it in my previous pr :(

Release note (sql change): 16 is used as the default bucket count
for hash sharded index.

@cockroach-teamcity
Copy link
Member

This change is Reviewable

for some reason I forgot to modify it in my previous pr.

Release note (sql change): 16 is used as the default bucket count
for hash sharded index.
@chengxiong-ruan chengxiong-ruan force-pushed the use-16-as-default-bucket-count branch from f946b3b to 1ea5e41 Compare February 9, 2022 03:30
@chengxiong-ruan chengxiong-ruan marked this pull request as ready for review February 9, 2022 05:18
@chengxiong-ruan chengxiong-ruan requested review from a team, postamar and ajwerner February 9, 2022 05:18
Copy link
Contributor

@ajwerner ajwerner left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

:lgtm:

Reviewed 4 of 4 files at r1, all commit messages.
Reviewable status: :shipit: complete! 1 of 0 LGTMs obtained (waiting on @postamar)

@chengxiong-ruan
Copy link
Contributor Author

thanks for the review!
bors r+

@craig
Copy link
Contributor

craig bot commented Feb 9, 2022

Build failed (retrying...):

@craig
Copy link
Contributor

craig bot commented Feb 9, 2022

Build failed (retrying...):

@craig
Copy link
Contributor

craig bot commented Feb 9, 2022

Build succeeded:

@craig craig bot merged commit c7446c5 into cockroachdb:master Feb 9, 2022
@chengxiong-ruan chengxiong-ruan deleted the use-16-as-default-bucket-count branch February 10, 2022 15:33
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants