Commit
This commit does not belong to any branch on this repository, and may belong to a fork outside of the repository.
91698: ui: txn insights v2 r=xinhaoz a=xinhaoz Closes #91696 Closes #88847 For the next version of txn insights, we want to show the insights of the stmts involved in the txn. This commit aggregates stmt insights to show at the txn level on the txn insights overview page and the details page. Previously, the txn insights only showed contention information, which we pull from a different source (contention registry over insights system). To preserve the information we were already showing, the aggregated stmt insights were merged with the previous data. Some considerations to be addressed in future PRs: 1. We don't currently track txn start and end time in the insights system. Since there is no guarantee that a txn in the contention registry has an entry in the insights system, there is currently a gap in execution details for txn contention insights being displayed. 2. For insights we only display the most recent txn execution for a txn fingerprint that has an insight. Since the insights system does not track txn end time, we can't know which executed more recently when we have a txn from the contention response and one from the insights response with the same fingerprint, so for now we default to showing the contention insight. Release note (ui change): Txn insights pages now show insights about slow execution with unknown causes, plan regressions, index recommendations, and failed executions. The following fields have also been added on the details page, but are not available for txns where the insight is 'High Contention': - User name - Session ID - rows processed - rows read - rows written - retries - last retry reason - Full scan - Transaction priority <img width="1529" alt="image" src="https://user-images.githubusercontent.com/20136951/201197631-d617b418-57eb-4aff-aaf6-0bc426591f53.png"> <img width="1392" alt="image" src="https://user-images.githubusercontent.com/20136951/201197674-db90b47a-cf52-4cb8-a19d-3c22d0668e77.png"> Image below contains a fixed bug seen in loom where time spent waiting showed NaN <img width="1525" alt="image" src="https://user-images.githubusercontent.com/20136951/201198013-e3f7cc78-f711-4759-88f6-e3f7f16da328.png"> https://www.loom.com/share/640d0e464d1c40978d44ea1df8ac4581 CC Console Insight pages: https://www.loom.com/share/4b01cef66aec4c1aa5a7f44b9a962237 91837: deps: update to cockroach-go 2.2.18 r=rafiss a=rafiss The testserver changes are needed to support mixed version logic tests. informs #72451 Release note: None 91866: jobsprotectedccl: skip flaky test r=miretskiy a=knz Informs #91865. Co-authored-by: Xin Hao Zhang <[email protected]> Co-authored-by: Rafi Shamim <[email protected]> Co-authored-by: Raphael 'kena' Poss <[email protected]>
- Loading branch information
