-
Notifications
You must be signed in to change notification settings - Fork 3.8k
Commit
This commit does not belong to any branch on this repository, and may belong to a fork outside of the repository.
Closes #91696 For the next version of txn insights, we want to show the insights of the stmts involved in the txn. This commit aggregates stmt insights to show at the txn level on the txn insights overview page and the details page. Previously, the txn insights only showed contention information, which we pull from a different source (contention registry over insights system). To preserve the information we were already showing, the aggregated stmt insights were merged with the previous data. Some considerations to be addressed in future PRs: 1. We don't currently track txn start and end time in the insights system. Since there is no guarantee that a txn in the contention registry has an entry in the insights system, there is currently a gap in execution details for txn contention insights being displayed. 2. For insights we only display the most recent txn execution for a txn fingerprint that has an insight. Since the insights system does not track txn end time, we can't know which executed more recently when we have a txn from the contention response and one from the insights response with the same fingerprint, so for now we default to showing the contention insight. Release note (ui change): Txn insights pages now show insights about slow execution with unknown causes, index recommendations, and failed executions. The following fields have also been added on the details page, but are not available for txns where the insight is 'High Contention': - User name - Session ID - rows processed - rows read - rows written - retries - last retry reason - Full scan - Transaction priority
- Loading branch information
Showing
36 changed files
with
1,257 additions
and
1,029 deletions.
There are no files selected for viewing
Large diffs are not rendered by default.
Oops, something went wrong.
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Oops, something went wrong.