Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Listen on event for image build #507

Merged
merged 1 commit into from
Oct 14, 2020
Merged

Conversation

marusak
Copy link
Member

@marusak marusak commented Aug 12, 2020

In containers/podman#7202 a new event was
introduced. Listen on it as well.

This is not going to work out just now, but I am opening it now, so we won't forget. Once new podman (I guess 2.0.5 should get it) is out and in our VMs, we can nicely verify it with retrying tests in this PR.

In containers/podman#7202 a new event was
introduced. Listen on it as well.
@marusak marusak removed the blocked label Oct 10, 2020
@marusak marusak requested a review from KKoukiou October 10, 2020 04:29
@marusak
Copy link
Member Author

marusak commented Oct 10, 2020

Finally it landed in all images so is ready. @KKoukiou can you please take a look? Thanks!

@marusak marusak requested a review from croissanne October 13, 2020 17:28
Copy link
Contributor

@croissanne croissanne left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

looks good! Add fixes# & closes#?

@marusak marusak merged commit 75fc8b5 into cockpit-project:master Oct 14, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants