Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

add event for image build #7202

Merged
merged 1 commit into from
Aug 12, 2020
Merged

Conversation

baude
Copy link
Member

@baude baude commented Aug 3, 2020

upon image build completion, a new image type event is written for "build". more intricate details, like pulling an image, that might be done by build must be implemented in different vendored packages only after libpod is split from podman.

Fixes: #7022

Signed-off-by: Brent Baude [email protected]

@openshift-ci-robot openshift-ci-robot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Aug 3, 2020
libpod/image/image.go Outdated Show resolved Hide resolved
@openshift-ci-robot
Copy link
Collaborator

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: baude

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@baude
Copy link
Member Author

baude commented Aug 12, 2020

ready for merge when tests pass

upon image build completion, a new image type event is written for "build". more intricate details, like pulling an image, that might be done by build must be implemented in different vendored packages only after libpod is split from podman.

Fixes: containers#7022

Signed-off-by: Brent Baude <[email protected]>
@rhatdan
Copy link
Member

rhatdan commented Aug 12, 2020

LGTM

@rhatdan
Copy link
Member

rhatdan commented Aug 12, 2020

@mheon
Copy link
Member

mheon commented Aug 12, 2020

/lgtm

@openshift-ci-robot openshift-ci-robot added the lgtm Indicates that a PR is ready to be merged. label Aug 12, 2020
@openshift-merge-robot openshift-merge-robot merged commit b73c78d into containers:master Aug 12, 2020
marusak added a commit to marusak/cockpit-podman that referenced this pull request Aug 12, 2020
In containers/podman#7202 a new event was
introduced. Listen on it as well.
marusak added a commit to cockpit-project/cockpit-podman that referenced this pull request Oct 14, 2020
In containers/podman#7202 a new event was
introduced. Listen on it as well.

Closes #507
@baude baude deleted the buildevent branch May 18, 2022 15:19
@github-actions github-actions bot added the locked - please file new issue/PR Assist humans wanting to comment on an old issue or PR with locked comments. label Sep 21, 2023
@github-actions github-actions bot locked as resolved and limited conversation to collaborators Sep 21, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. lgtm Indicates that a PR is ready to be merged. locked - please file new issue/PR Assist humans wanting to comment on an old issue or PR with locked comments.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

APIv2: No events on image build
5 participants