Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add iosScrollToTop in cobalt.conf #109

Closed
5 tasks done
ggendre opened this issue May 10, 2016 · 3 comments
Closed
5 tasks done

Add iosScrollToTop in cobalt.conf #109

ggendre opened this issue May 10, 2016 · 3 comments
Assignees
@ggendre
Labels
enhancement platform:ios
Milestone
0.6

Comments

@ggendre
Copy link
Contributor

ggendre commented May 10, 2016 •
edited
Loading

Enable developer to activate the scroll to top gesture (a simple tap in the status bar) on the controller he wants.

Handle iosScrollToTop:true/false in cobalt.conf on iOS. Default should be false.

This would enable scroll to top on the Cobalt webview only. We can not enable this if the developper has other scrolling native components in his view

  • Handle on iOS
  • Add a sample of this in Catalog App
  • Write a quick blog post
  • Set default to true
  • Update cobalt.conf doc
@ggendre ggendre modified the milestone: 0.6 May 26, 2016
@ggendre ggendre added the ready label Jun 9, 2016
Doc1faux pushed a commit to cobaltians/Cobalt-iOS that referenced this issue Jun 30, 2016
cobaltians/Cobalt#109: add this feature native side
1ccda8b
@Doc1faux Doc1faux removed their assignment Jun 30, 2016
ggendre added a commit to Cobaltians-Samples/Samples-Catalog-Web that referenced this issue Jul 5, 2016
@ggendre
created a test branch for cobaltians/Cobalt#109
3491cdc
ggendre added a commit to Cobaltians-Samples/Samples-Catalog-iOS that referenced this issue Jul 5, 2016
@ggendre
updated catalog for feature cobaltians/Cobalt#109
25966e5
@ggendre ggendre closed this as completed Jul 5, 2016
ggendre added a commit to Cobaltians-Samples/Samples-Catalog-Android that referenced this issue Jul 5, 2016
@ggendre
using submodules for cobaltians/Cobalt#106 and cobaltians/Cobalt#109
031750c
@ggendre
Copy link
Contributor Author

ggendre commented Jul 15, 2016

I think we should change default to true. what do you think ?

@Doc1faux
Copy link
Contributor

You're a weathercock :P You told me that Cobalt should not "surpass" the native by enabling the WebView to respond to the scrollsToTop and now, you do not want?

@ggendre ggendre reopened this Jul 18, 2016
@ggendre
Copy link
Contributor Author

ggendre commented Jul 18, 2016

as seen together in the doc, the default value should be true

@ggendre ggendre assigned Doc1faux and ggendre and unassigned ggendre Jul 18, 2016
Doc1faux pushed a commit to cobaltians/Cobalt-iOS that referenced this issue Jul 21, 2016
cobaltians/Cobalt#109: default true
dfef809
Doc1faux pushed a commit to cobaltians/Cobalt-iOS that referenced this issue Jul 21, 2016
cobaltians/Cobalt#109: fix issue if key is not defined...
adc7b42
@Doc1faux Doc1faux removed their assignment Jul 21, 2016
@ggendre ggendre closed this as completed Jul 26, 2016
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@ggendre ggendre

Labels
enhancement platform:ios
Projects
None yet
Milestone
0.6
Development

No branches or pull requests
2 participants
@ggendre @Doc1faux