Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

set cobalt view background colors from cobalt.conf #106

Closed
13 tasks done
ggendre opened this issue May 10, 2016 · 6 comments
Closed
13 tasks done

set cobalt view background colors from cobalt.conf #106

ggendre opened this issue May 10, 2016 · 6 comments
Assignees
@ggendre
Labels
enhancement platform:android platform:ios
Milestone
0.6

Comments

@ggendre
Copy link
Contributor

ggendre commented May 10, 2016 •
edited
Loading

It could be great to define the background color of the cobalt views from the cobalt.conf controllers configuration.

This enable apps to have a custom background, that will be seen when the webview is loading and when the user is pullToRefreshing.

A simple backgroundColor : #008FD6 in the cobalt.conf would do the job.

Use the same colors detection as we used in bars

  • Handle on iOS
  • Handle on Android
  • Add a sample of this in Catalog App
  • Test navigation/dark simple page and PTR/coulouredPTR page on Android for the win
  • Write a quick blog post
  • merge feature-106 on catalog develop.
  • rename it form background to backgroundColor on web sample
  • rename it form background to backgroundColor on iOS
  • Apply color on root view instead of the WebView and apply clear color for this one on iOS
  • rename it form background to backgroundColor on Android
  • update sidemenu sample to use it aswell
  • Test Android Catalog and Android Sidemenu Sample because @ggendre is having graddle issues on his mac. Then, move to "Done".
  • fixed cobalt.conf on develop line 10 ""backgroundColor": "#19E9FF"," kill the comma !
@ggendre ggendre modified the milestone: 0.6 May 26, 2016
@ggendre ggendre added the ready label Jun 9, 2016
@Doc1faux
Copy link
Contributor

Default value: white

Doc1faux pushed a commit to cobaltians/Cobalt-iOS that referenced this issue Jun 28, 2016
cobaltians/Cobalt#106: add background feature to iOS
df0e0be
@Doc1faux
Copy link
Contributor

Done iOS side

@Doc1faux Doc1faux removed their assignment Jun 28, 2016
Myrdhinn added a commit to cobaltians/Cobalt-Android that referenced this issue Jun 29, 2016
@Myrdhinn
cobaltians/Cobalt#106 : add background color to webview android
4002a71
@ggendre ggendre reopened this Jun 29, 2016
@ggendre
Copy link
Contributor Author

ggendre commented Jun 29, 2016

reopened for the com part and updated issue with missing tasks

Doc1faux pushed a commit to cobaltians/Cobalt-iOS that referenced this issue Jun 30, 2016
cobaltians/Cobalt#106: add missing default value if controller config…
99b05c8 
…uration is not found
ggendre added a commit to Cobaltians-Samples/Samples-Catalog-Web that referenced this issue Jun 30, 2016
@ggendre
cobaltians/Cobalt#106 forgot colored background for simple page
6b543b6
ggendre added a commit to Cobaltians-Samples/Samples-Catalog-Web that referenced this issue Jun 30, 2016
@ggendre
cobaltians/Cobalt#106 better color
4846fa9
ggendre added a commit to Cobaltians-Samples/Samples-Catalog-iOS that referenced this issue Jun 30, 2016
@ggendre
cobaltians/Cobalt#106 using feature-106 submodule for web (and latest…
ec2c0ac 
… develop for cobalt-ios)
ggendre added a commit to Cobaltians-Samples/Samples-Catalog-Android that referenced this issue Jun 30, 2016
@ggendre
cobaltians/Cobalt#106 using feature-106 submodule for common and late…
5f7fab0 
…st develop for cobalt
@ggendre
Copy link
Contributor Author

ggendre commented Jun 30, 2016

created a branch feature-106 for web, android and ios Ctalaog sample.

iOS Catalog works great. haven't teste Android Catalog yet.

@Myrdhinn Myrdhinn removed their assignment Jul 5, 2016
ggendre added a commit to Cobaltians-Samples/Samples-Catalog-Android that referenced this issue Jul 5, 2016
@ggendre
using submodules for cobaltians/Cobalt#106 and cobaltians/Cobalt#109
031750c
ggendre added a commit to Cobaltians-Samples/Samples-Catalog-iOS that referenced this issue Jul 5, 2016
@ggendre
using submodules for cobaltians/Cobalt#106
b4451e1
@ggendre
Copy link
Contributor Author

ggendre commented Jul 5, 2016

added tasks to change attribute name from background to backgroundColor.

@Doc1faux Doc1faux mentioned this issue Jul 6, 2016
Open
18 tasks
Myrdhinn added a commit to cobaltians/Cobalt-Android that referenced this issue Jul 6, 2016
@Myrdhinn
cobaltians/Cobalt#106 : rename backgroundColor
48172f6
@Myrdhinn Myrdhinn removed their assignment Jul 6, 2016
Myrdhinn added a commit to cobaltians/Cobalt-Android that referenced this issue Jul 6, 2016
@Myrdhinn
cobaltians/Cobalt#106 : fix miss rename backgroundcolor
c190050
Doc1faux pushed a commit to cobaltians/Cobalt-iOS that referenced this issue Jul 7, 2016
cobaltians/Cobalt#106: rename background key to backgroundColor. Appl…
1da9dd7 
…y color to root view instead of WebView and apply clearColor on this one.
Doc1faux pushed a commit to Cobaltians-Samples/Samples-Catalog-iOS that referenced this issue Jul 7, 2016
cobaltians/Cobalt#106: apply last Cobalt-iOS update to Catalog
0e4d854
@Doc1faux Doc1faux removed their assignment Jul 7, 2016
ggendre added a commit to Cobaltians-Samples/Samples-Catalog-iOS that referenced this issue Jul 15, 2016
@ggendre
cobaltians/Cobalt#106: apply last Cobalt-iOS update to Catalog
6ce9112
ggendre added a commit to Cobaltians-Samples/Samples-Catalog-Web that referenced this issue Jul 15, 2016
@ggendre
cobaltians/Cobalt#106 renamed prop to backgroundColor
102d73c
ggendre added a commit to Cobaltians-Samples/Samples-Catalog-iOS that referenced this issue Jul 15, 2016
@ggendre
cobaltians/Cobalt#106 using latest www/common sources
086b232
ggendre added a commit to Cobaltians-Samples/Samples-Catalog-Android that referenced this issue Jul 15, 2016
@ggendre
cobaltians/Cobalt#106 using latest www/common sources
fd9cc5c
ggendre added a commit to Cobaltians-Samples/Samples-SideMenu-iOS that referenced this issue Jul 15, 2016
@ggendre
cobaltians/Cobalt#106 using backgroundColor from .conf
cf0f2c4
ggendre added a commit to Cobaltians-Samples/Samples-SideMenu-Android that referenced this issue Jul 15, 2016
@ggendre
cobaltians/Cobalt#106 using backgroundColor from .conf
723a854
@ggendre ggendre assigned Myrdhinn and unassigned ggendre Jul 15, 2016
@Myrdhinn
Copy link
Contributor

Test Android on branch develop Catalog and SideMenuSample - OK
Added task to fix error Web side in cobalt.conf

@Myrdhinn Myrdhinn assigned ggendre and unassigned Myrdhinn Jul 21, 2016
ggendre added a commit to Cobaltians-Samples/Samples-SideMenu-Web that referenced this issue Jul 26, 2016
@ggendre
cobaltians/Cobalt#106 fixed coma
52b214f
ggendre added a commit to Cobaltians-Samples/Samples-SideMenu-iOS that referenced this issue Jul 26, 2016
@ggendre
cobaltians/Cobalt#106 updated to latest cobalt.js and common files
30c4c1f
ggendre added a commit to Cobaltians-Samples/Samples-SideMenu-Android that referenced this issue Jul 26, 2016
@ggendre
cobaltians/Cobalt#106 updated to latest common web files
272ad56
@ggendre ggendre closed this as completed Jul 26, 2016
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@ggendre ggendre

Labels
enhancement platform:android platform:ios
Projects
None yet
Milestone
0.6
Development

No branches or pull requests
3 participants
@ggendre @Doc1faux @Myrdhinn