Remove trailing space from pyflakes project #637
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jayvdb
requested changes
Aug 13, 2018
netlify.toml
Outdated
| @@ -1,3 +1,7 @@ | |||
| [build] | |||
| publish = "_site" | |||
| command = "gem install bundler && .ci/build.sh" | |||
|
|
|||
| [[redirects]] | |||
| from = "/#/projects?project=integrate_pyflakes-enhanced_ast_into_coala" | |||
There was a problem hiding this comment.
to & from need to be reversed.
and you need to edit the .md to remove the unwanted space
srivama
force-pushed
the
issue573-patch1-removing-trailing-underscore
branch
from
caa0142 to
c1cd2b7
Compare
|
netlify redirect isnt working. see #573 (comment) |
jayvdb
changed the title
srivama
force-pushed
the
issue573-patch1-removing-trailing-underscore
branch
from
c1cd2b7 to
7c330ee
Compare
|
Interesting. I dont seem to be able to get the popup to work with other pages. |
|
See it works on master https://coala-projects.netlify.com/#/projects?project=improve_generic_bear_quality |
jayvdb
requested changes
Sep 1, 2018
srivama
force-pushed
the
issue573-patch1-removing-trailing-underscore
branch
from
7c330ee to
77f158e
Compare
shikharvaish28
suggested changes
Sep 3, 2018
resources/js/app.js
Outdated
| @@ -262,6 +269,11 @@ | |||
|
|
|||
| var project_requested = encodeURIComponent($location.search().project); | |||
| if(project_requested){ | |||
|
|
|||
There was a problem hiding this comment.
IMO we don't this extra line here.
There was a problem hiding this comment.
At some places it exists, and at some it doesn't. I'll remove it anyway
resources/js/app.js
Outdated
| if(project_requested in redirectTo){ | ||
| project_requested = redirectTo[project_requested] | ||
| } | ||
|
|
srivama
force-pushed
the
issue573-patch1-removing-trailing-underscore
branch
from
77f158e to
7a6097b
Compare
|
Yes, it's an old commit. I'll rebase once the code changes are approved. John needs to deploy and verify that the redirects are working properly. |
|
The netlify deploy is working. See the test below. |
This redirects the user from link http://projects.coala.io/#/projects?project=integrate_pyflakes-enhanced_ast_into_coala_ to http://projects.coala.io/#/projects?project=integrate_pyflakes-enhanced_ast_into_coala and also removes ending whitespace from project name Fixes coala#573
srivama
force-pushed
the
issue573-patch1-removing-trailing-underscore
branch
from
7a6097b to
1d3d026
Compare
Travis tests have failedHey @srivama, Ruby: 2.5.1docker run -v=$(pwd):/app --workdir=/app coala/base coala --ci |
Travis tests have failedHey @srivama, Ruby: 2.5.1docker run -v=$(pwd):/app --workdir=/app coala/base coala --ci |
|
ack 1d3d026 |
jayvdb
approved these changes
Sep 20, 2018
|
@gitmate-bot ff |
|
Hey! I'm GitMate.io! This pull request is being fastforwarded automatically. Please DO NOT push while fastforward is in progress or your changes would be lost permanently |
|
Automated fastforward with GitMate.io was successful! 🎉 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This redirects the user from link
http://projects.coala.io/#/projects?project=integrate_pyflakes-enhanced_ast_into_coala_
to http://projects.coala.io/#/projects?project=integrate_pyflakes-enhanced_ast_into_coala
Fixes #573
For short term contributors: we understand that getting your commits well
defined like we require is a hard task and takes some learning. If you
look to help without wanting to contribute long term there's no need
for you to learn this. Just drop us a message and we'll take care of brushing
up your stuff for merge!
Checklist
them.
individually. It is not sufficient to have "fixup commits" on your PR,
our bot will still report the issues for the previous commit.) You will
likely receive a lot of bot comments and build failures if coala does not
pass on every single commit!
After you submit your pull request, DO NOT click the 'Update Branch' button.
When asked for a rebase, consult coala.io/rebase
instead.
Please consider helping us by reviewing other peoples pull requests as well:
cobot mark wip <URL>to get it outof the review queue.
The more you review, the more your score will grow at coala.io and we will
review your PRs faster!