Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Remove trailing underscore in pyflakes URL #573

Closed
jayvdb opened this issue May 12, 2018 · 7 comments · Fixed by #637
Closed

Remove trailing underscore in pyflakes URL #573

jayvdb opened this issue May 12, 2018 · 7 comments · Fixed by #637
Assignees
@srivama
Labels
difficulty/low importance/low

Comments

@jayvdb
Copy link
Member

jayvdb commented May 12, 2018

The pyflakes project link is
http://projects.coala.io/#/projects?project=integrate_pyflakes-enhanced_ast_into_coala_

Without the underscore it doesnt work.

http://projects.coala.io/#/projects?project=integrate_pyflakes-enhanced_ast_into_coala

We need both to work, and the former redirect to the latter.

It might be possible to use Netlify _redirects to do the redirect.
@devesh-verma
Copy link
Member

@jayvdb hey I would like to work on this

@jayvdb
Copy link
Member Author

jayvdb commented May 23, 2018

Assigned.

@jayvdb
Copy link
Member Author

jayvdb commented May 23, 2018

Wow, you have also been assigned to #529 for ages, and not done anything.
You'll be unassigned soon if you dont submit a PR.

@devesh-verma
Copy link
Member

u can unassign me from #529 👍

@devesh-verma
Copy link
Member

@jayvdb hey can you plz tell me where to make the change? I was not able to find the links in project.

@jayvdb jayvdb assigned srivama and unassigned devesh-verma Aug 12, 2018
@srivama
Copy link
Contributor

srivama commented Aug 12, 2018

How about we directly add the redirects in the netlify.toml file instead of creating a new _redirects file?

srivama added a commit to srivama/projects that referenced this issue Aug 13, 2018
@srivama
netlify.toml: Add redirect for pyflakes project
caa0142 
This redirects the user from link
http://projects.coala.io/#/projects?project=integrate_pyflakes-enhanced_ast_into_coala
to http://projects.coala.io/#/projects?project=integrate_pyflakes-enhanced_ast_into_coala_

Fixes coala#573
@srivama srivama mentioned this issue Aug 13, 2018
Merged
2 tasks
srivama added a commit to srivama/projects that referenced this issue Aug 13, 2018
@srivama
netlify.toml: Add redirect for pyflakes project
c1cd2b7 
This redirects the user from link
http://projects.coala.io/#/projects?project=integrate_pyflakes-enhanced_ast_into_coala_
to http://projects.coala.io/#/projects?project=integrate_pyflakes-enhanced_ast_into_coala

Fixes coala#573
@jayvdb
Copy link
Member Author

jayvdb commented Aug 13, 2018

As this is a Single Page App, the netlify redirect probably wont work.

Might need some voodoo in the angular JS

srivama added a commit to srivama/projects that referenced this issue Aug 13, 2018
@srivama
app.js: Add redirect for pyflakes project
7c330ee 
This redirects the user from link
http://projects.coala.io/#/projects?project=integrate_pyflakes-enhanced_ast_into_coala_
to http://projects.coala.io/#/projects?project=integrate_pyflakes-enhanced_ast_into_coala
and also removes ending whitespace from project name

Fixes coala#573
srivama added a commit to srivama/projects that referenced this issue Sep 3, 2018
@srivama
app.js: Add redirect for pyflakes project
77f158e 
This redirects the user from link
http://projects.coala.io/#/projects?project=integrate_pyflakes-enhanced_ast_into_coala_
to http://projects.coala.io/#/projects?project=integrate_pyflakes-enhanced_ast_into_coala
and also removes ending whitespace from project name

Fixes coala#573
srivama added a commit to srivama/projects that referenced this issue Sep 3, 2018
@srivama
app.js: Add redirect for pyflakes project
7a6097b 
This redirects the user from link
http://projects.coala.io/#/projects?project=integrate_pyflakes-enhanced_ast_into_coala_
to http://projects.coala.io/#/projects?project=integrate_pyflakes-enhanced_ast_into_coala
and also removes ending whitespace from project name

Fixes coala#573
srivama added a commit to srivama/projects that referenced this issue Sep 20, 2018
@srivama
app.js: Add redirect for pyflakes project
1d3d026 
This redirects the user from link
http://projects.coala.io/#/projects?project=integrate_pyflakes-enhanced_ast_into_coala_
to http://projects.coala.io/#/projects?project=integrate_pyflakes-enhanced_ast_into_coala
and also removes ending whitespace from project name

Fixes coala#573
rahuldkjain pushed a commit to rahuldkjain/projects that referenced this issue Oct 11, 2018
@srivama
app.js: Add redirect for pyflakes project
2b0297b 
This redirects the user from link
http://projects.coala.io/#/projects?project=integrate_pyflakes-enhanced_ast_into_coala_
to http://projects.coala.io/#/projects?project=integrate_pyflakes-enhanced_ast_into_coala
and also removes ending whitespace from project name

Fixes coala#573
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@srivama srivama

Labels
difficulty/low importance/low
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Remove trailing space from pyflakes project srivama/projects
3 participants
@jayvdb @srivama @devesh-verma