Re-activate coala-ci #397
Merged
Re-activate coala-ci #397
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
sims1253
reviewed
Nov 2, 2017
.travis.yml
Outdated
| script: ./ci/cibuild | ||
| script: | ||
| - ./ci/cibuild | ||
| - docker run -v=$(pwd):/app --workdir=/app coala/base coala --ci |
There was a problem hiding this comment.
is the /app actually working in this case? Shouldn't it point to the projects directory?
There was a problem hiding this comment.
See User Docker documentation
.coafile
Outdated
| files = **.yml, **.html, **.md, **.js, **.css, **.json | ||
| ignore = vendor/**, resources/vendors/**, _site/** | ||
| link_ignore_regex = (twitter.com|githubusercontent.com|github.com|gitlab.com|withgoogle.com|clbin.com) |
There was a problem hiding this comment.
why do we want to ignore all of these? github links for example might point to our wiki so they should work.
There was a problem hiding this comment.
because they return 404 for any bots.
This was the old config.
Someone deleted it, without an issue to describe why.
There was a problem hiding this comment.
then please add a comment mentioning that 👍
There was a problem hiding this comment.
Here is the removal 6e75373176735 (#297)
| @@ -292,6 +292,6 @@ Apart from that, there's also scope to extract useful information from meta file | |||
|
|
|||
| #### Thanks giving! | |||
|
|
|||
| Thanks a lot to all my fellow coalians for making my so far wonderful journey with coala. It's been around 9 months since I started contributing to coala and I've learned a lot till now. A very very special thanks to [Adhityaa](https://gihub.com/adtac) for helping me constantly throughout the summer despite of his own internship. He was quick in doing critical code reviews and absolutely a fun mentor to work with (not to mention the interesting conversations between [Adrian](https://github.com/Adrianzatreanu) and him during the initial weekly meetings). | |||
| Thanks a lot to all my fellow coalians for making my so far wonderful journey with coala. It's been around 9 months since I started contributing to coala and I've learned a lot till now. A very very special thanks to [Adhityaa](https://github.com/adtac) for helping me constantly throughout the summer despite of his own internship. He was quick in doing critical code reviews and absolutely a fun mentor to work with (not to mention the interesting conversations between [Adrian](https://github.com/Adrianzatreanu) and him during the initial weekly meetings). | |||
There was a problem hiding this comment.
Is the only change here - -> + ?
If so, why? we now use *, - and + for list points in this file.
There was a problem hiding this comment.
The change here is gihub.com->github.com
neelanshsahai
suggested changes
Nov 8, 2017
| @@ -292,6 +292,6 @@ Apart from that, there's also scope to extract useful information from meta file | |||
|
|
|||
| #### Thanks giving! | |||
|
|
|||
| Thanks a lot to all my fellow coalians for making my so far wonderful journey with coala. It's been around 9 months since I started contributing to coala and I've learned a lot till now. A very very special thanks to [Adhityaa](https://gihub.com/adtac) for helping me constantly throughout the summer despite of his own internship. He was quick in doing critical code reviews and absolutely a fun mentor to work with (not to mention the interesting conversations between [Adrian](https://github.com/Adrianzatreanu) and him during the initial weekly meetings). | |||
| Thanks a lot to all my fellow coalians for making my so far wonderful journey with coala. It's been around 9 months since I started contributing to coala and I've learned a lot till now. A very very special thanks to [Adhityaa](https://github.com/adtac) for helping me constantly throughout the summer despite of his own internship. He was quick in doing critical code reviews and absolutely a fun mentor to work with (not to mention the interesting conversations between [Adrian](https://github.com/Adrianzatreanu) and him during the initial weekly meetings). | |||
There was a problem hiding this comment.
The first sentence seems to be Grammatically incorrect.
There was a problem hiding this comment.
That is not part of the issue this PR is solving, so it does not belong in this PR.
jayvdb
force-pushed
the
add-link-bear
branch
from
b4e4ed2 to
b0b3bf7
Compare
|
ack 2d4e987 |
jayvdb
force-pushed
the
add-link-bear
branch
from
b0b3bf7 to
6b8b4c8
Compare
|
ack 6b8b4c8 |
jayvdb
force-pushed
the
add-link-bear
branch
2 times, most recently
from
481070b to
20dcfaf
Compare
And fix one broken link to gihub.com.
|
ack 20dcfaf |
|
@rultor merge |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes #13