Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Hemangsk/css #297

Merged
merged 7 commits into from
May 24, 2017
Merged

Hemangsk/css #297

merged 7 commits into from
May 24, 2017

Conversation

hemangsk
Copy link
Member

@hemangsk hemangsk commented May 23, 2017

Short Note (same as landing-frontend)

This has a lot of changes in all the partials file. These changes are large in number, but essentially they do only these four tasks,

  • Removes Bootstrap's class and use MaterializeCSS grid classes.
  • Uses classes available in coalaCSS and restructures the divs accordingly if required.
  • Indentation and removal of extra newlines.
  • Lastly, Introduces the usage of coalaCSS via CDN link from rawgit. Its a CSS theme which we can use throughout web projects at coala.

It will be really awesome if someone can help me test the changes! So to fetch these new changes and to test locally,

git clone https://github.com/coala/projects.git
cd projects
git fetch origin pull/297/head:hemangsk/css
git checkout hemangsk/css
python -m SimpleHTTPServer 8080 # python2
# or
python3 -m http.server 8080 #python3

Visit localhost:8080 in browser to view the site running.
Thanks ☺️

For short term contributors: we understand that getting your commits well
defined like we require is a hard task and takes some learning. If you
look to help without wanting to contribute long term there's no need
for you to learn this. Just drop us a message and we'll take care of brushing
up your stuff for merge!

Checklist

  • I read the commit guidelines and I've followed
    them.
  • I ran coala over my code locally. (All commits have to pass
    individually.
    It is not sufficient to have "fixup commits" on your PR,
    our bot will still report the issues for the previous commit.) You will
    likely receive a lot of bot comments and build failures if coala does not
    pass on every single commit!

After you submit your pull request, DO NOT click the 'Update Branch' button.
When asked for a rebase, consult coala.io/rebase
instead.

Please consider helping us by reviewing other peoples pull requests as well:

The more you review, the more your score will grow at coala.io and we will
review your PRs faster!

@hemangsk hemangsk force-pushed the hemangsk/css branch 2 times, most recently from b1291ff to 9e80894 Compare May 23, 2017 16:47
</div>
</div>
</div>
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

trailing whitespace in 974c030

@sils
Copy link
Member

sils commented May 24, 2017

hemangsk added 3 commits May 24, 2017 14:34
- Use coalaCSS classes
- Use Materialize for containers, rows and columns
@hemangsk
Copy link
Member Author

reack 7292161 ca045ca

@hemangsk
Copy link
Member Author

reack 7292161

@sils
Copy link
Member

sils commented May 24, 2017

ack ae88834

@sils sils merged commit 4a9450b into master May 24, 2017
@sils sils deleted the hemangsk/css branch May 24, 2017 09:20
@jayvdb jayvdb mentioned this pull request Nov 16, 2017
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Development

Successfully merging this pull request may close these issues.

3 participants