-
Notifications
You must be signed in to change notification settings - Fork 579
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add support for yapf>=0.21.0<0.27.0 and fix filename in .ci/generate_bear_metadata.py #2880
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Needs a rebase
Done. |
Refetch master bear-requirements.yaml Use |
I'm running into:
and I suspect this is because running New issue? Although this is probably just a change in coala-bears/.ci/generate_bear_metadata.py Line 461 in afb068b
|
Yup; new issue. That is a bug in my PR. |
You can add the fix to this PR as a separate commit. |
e6e5f88
to
6926c0e
Compare
Done. |
Sorry ; wrong button press. @areebbeigh , this needs another rebase, but please also revise your commit messages to follow the coala commit guidelines. specifically the first line should start with a filename of the most important file in the commit which is being modified (usually not a file which is generated). |
Modify test_allow_multiline_lambdas to be version specific. Closes coala#2873
Change "overrides" filename from package-manager-requirements.yaml to pm-requirements.yaml Fixes coala#2936
I'm going to merge this despite it failing due to #2937 , which I'll fix after this is merged |
Modify test_allow_multiline_lambdas to be
version specific.
Closes #2873
Change "overrides" filename from
package-manager-requirements.yaml to pm-requirements.yaml
Fixes #2936
Checklist
them.
individually. It is not sufficient to have "fixup commits" on your PR,
our bot will still report the issues for the previous commit.) You will
likely receive a lot of bot comments and build failures if coala does not
pass on every single commit!