Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

PyImportSortBear.py: passing known_third_party to isort_settings #1513

Closed
wants to merge 1 commit into from
Closed

PyImportSortBear.py: passing known_third_party to isort_settings #1513

wants to merge 1 commit into from

Conversation

madhukar01
Copy link
Contributor

known_third_party_imports was being passed to the run fucntion but it was not being
passed to the wrapper function isort_settings. This update fixes the issue.

Fixes #1510

For short term contributors: we understand that getting your commits well
defined like we require is a hard task and takes some learning. If you
look to help without wanting to contribute long term there's no need
for you to learn this. Just drop us a message and we'll take care of brushing
up your stuff for merge!

Checklist

  • I read the commit guidelines and I've followed
    them.
  • I ran coala over my code locally. (All commits have to pass
    individually.
    It is not sufficient to have "fixup commits" on your PR,
    our bot will still report the issues for the previous commit.) You will
    likely receive a lot of bot comments and build failures if coala does not
    pass on every single commit!

After you submit your pull request, DO NOT click the 'Update Branch' button.
When asked for a rebase, consult coala.io/rebase
instead.

Please consider helping us by reviewing other peoples pull requests as well:

The more you review, the more your score will grow at coala.io and we will
review your PRs faster!

known_third_party_imports was being passed to the run fucntion but it was not being
passed to the wrapper function isort_settings. This update fixes the issue.

Fixes #1510
@gitmate-bot
Copy link
Collaborator

Comment on 5c9331d.

Body of HEAD commit contains too long lines. Commit body lines should not exceed 72 characters.

GitCommitBear, severity NORMAL, section commit.

@gitmate-bot
Copy link
Collaborator

Comment on 5c9331d.

Shortlog of HEAD commit isn't in imperative mood! Bad words are 'passing'

GitCommitBear, severity NORMAL, section commit.

@gitmate-bot
Copy link
Collaborator

Comment on 5c9331d.

Shortlog of HEAD commit does not match given regex: ([^:]|[^:]+: [A-Z0-9].*)

GitCommitBear, severity NORMAL, section commit.

@gitmate-bot
Copy link
Collaborator

Comment on 5c9331d.

Shortlog of the HEAD commit contains 64 character(s). This is 14 character(s) longer than the limit (64 > 50).

GitCommitBear, severity NORMAL, section commit.

Copy link
Contributor

@yashtrivedi96 yashtrivedi96 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Try to reduce the body of your commit message. Make 72 characters or less

Copy link
Contributor

@yashtrivedi96 yashtrivedi96 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Short description starts with capital letter.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Development

Successfully merging this pull request may close these issues.

PyImportSortBear: known_third_party_imports not passed to isort
3 participants