Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

PyImportSortBear: known_third_party_imports not passed to isort #1510

Closed
NiklasMM opened this issue Mar 13, 2017 · 0 comments
Closed

PyImportSortBear: known_third_party_imports not passed to isort #1510

NiklasMM opened this issue Mar 13, 2017 · 0 comments
Assignees
@madhukar01
Labels
difficulty/newcomer

Comments

@NiklasMM
Copy link
Contributor

NiklasMM commented Mar 13, 2017 •
edited
Loading

The option known_third_party_imports for PyImportSortBear is documented and taken as a parameter of run but it is not passed to the wrapped tool isort. It should be passed as known_third_party.

Could be a great newcomer issue
This was referenced Mar 14, 2017
Closed
Merged
@NiklasMM NiklasMM assigned madhukar01 and unassigned jack17529 Mar 22, 2017
gosom pushed a commit to gosom/coala-bears that referenced this issue Jul 15, 2017
@madhukar01
PyImportSortBear.py: Add missing parameter
2cd5420 
Add a missing parameter known_third_party to isort
function. It was being passed to the run function but
was missing in the wrapper.

Fixes coala#1510
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@madhukar01 madhukar01

Labels
difficulty/newcomer
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

PyImportSortBear.py: passing known_third_party to isort_settings
4 participants
@NiklasMM @meetmangukiya @jack17529 @madhukar01