Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

handle localbuild creation error and look for cluster scoped object #96

Merged
merged 1 commit into from
Nov 28, 2023
Merged

handle localbuild creation error and look for cluster scoped object #96

merged 1 commit into from
Nov 28, 2023

Conversation

nabuskey
Copy link
Collaborator

We should handle the error returned by CreateOrUpdate to ensure the CLI does not hang indefinitely when error is returned.

fixes: #94

GenPage
GenPage approved these changes Nov 28, 2023
View reviewed changes
Copy link

@GenPage GenPage left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

jessesanford
jessesanford approved these changes Nov 28, 2023
View reviewed changes
Copy link
Contributor

@jessesanford jessesanford left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@nabuskey nabuskey merged commit ab6d14d into cnoe-io:main Nov 28, 2023
2 checks passed
@nabuskey nabuskey deleted the fix/localbuild-err branch November 28, 2023 20:41
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@GenPage GenPage GenPage approved these changes

@jessesanford jessesanford jessesanford approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

[Bug]: Ensure error handling in build
3 participants
@nabuskey @jessesanford @GenPage