Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Bug]: Ensure error handling in build #94

Closed
nabuskey opened this issue Nov 22, 2023 · 0 comments · Fixed by #96
Closed

[Bug]: Ensure error handling in build #94

nabuskey opened this issue Nov 22, 2023 · 0 comments · Fixed by #96
Labels
bug Something isn't working

Comments

@nabuskey
Copy link
Collaborator

nabuskey commented Nov 22, 2023

What is your environment, configuration, and command?

The error returned here is ignored and we could end up in a limbo.

controllerutil.CreateOrUpdate(ctx, kubeClient, &localBuild, func() error {

Also, the localbuilder resources are cluster scoped. Specifying the default namespace ends up not triggering updates because runtime object and what we expect do not match. We should not specify namespace for this resource type.

https://github.com/kubernetes-sigs/controller-runtime/blob/2154ffbc22e26ffd8c3b713927f0df2fa40841f2/pkg/controller/controllerutil/controllerutil.go#L397

If CreateOrUpdate call fails, we should let the users know and exit.

Additional Information. Logs.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

Successfully merging a pull request may close this issue.

1 participant