Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

print url for codespaces #456

Merged
merged 1 commit into from
Nov 20, 2024
Merged

print url for codespaces #456

merged 1 commit into from
Nov 20, 2024

Conversation

nabuskey
Copy link
Collaborator

@nabuskey nabuskey commented Nov 20, 2024

This prints the correct URL when idpbuilder is used in Codespaces. We do promote the use of Codespaces to get going quickly so I think it's a good idea to have something small like this to make the experience better.

If you are using another proxy like Caddy instead, this prints out the URL correctly as well. You just need to set CODESPACES=true when running idpbuilder.

fixes: #269
fixes: #452

Signed-off-by: Manabu McCloskey <[email protected]>
@nabuskey nabuskey requested a review from blakeromano November 20, 2024 20:42
@nabuskey nabuskey merged commit d14289a into cnoe-io:main Nov 20, 2024
5 checks passed
@nabuskey nabuskey deleted the print branch November 20, 2024 21:30
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
2 participants