Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Bug]: <Fix argocd link in the idpbuilder create output in codespace> #269

Closed
SupriyaNallapeta opened this issue May 29, 2024 · 2 comments · Fixed by #456
Closed

[Bug]: <Fix argocd link in the idpbuilder create output in codespace> #269

SupriyaNallapeta opened this issue May 29, 2024 · 2 comments · Fixed by #456
Labels
bug Something isn't working

Comments

@SupriyaNallapeta
Copy link
Contributor

What is your environment, configuration, and command?

running idpbuilder create command in the Codespace as explained the README.

What did you do and What did you see instead?

In the codespace, the idpbuilder create command will give the invalid argocd url with port appended similar to this

Can Access ArgoCD at http://verbose-broccoli-jr5j59g5j7wh56x4-8080.app.github.dev:8080/argocd
Username: admin
Password can be retrieved by running: idpbuilder get secrets -p argocd

I would expect to see it as below,

Can Access ArgoCD at http://verbose-broccoli-jr5j59g5j7wh56x4-8080.app.github.dev/argocd
Username: admin
Password can be retrieved by running: idpbuilder get secrets -p argocd

related code: https://github.com/cnoe-io/idpbuilder/blob/main/pkg/cmd/create/root.go#L134
#267 (comment)

Additional Information. Logs.

No response

@SupriyaNallapeta SupriyaNallapeta added the bug Something isn't working label May 29, 2024
@nimakaviani
Copy link
Contributor

Closing this, as it was discussed and fixed in #267

@nabuskey
Copy link
Collaborator

Not fixed actually. If you run this in codespaces environment, the printed url at the end is incorrect. Specifically the port. This is not a codespaces specific problem either. If you are fronting this with another proxy, this problem applies. I'd imagine this will be relevant when deploying to remote clusters as well.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

Successfully merging a pull request may close this issue.

3 participants