Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: rename buildName flag to name #277

Closed
wants to merge 1 commit into from

Conversation

xoanmm
Copy link
Contributor

@xoanmm xoanmm commented Jun 4, 2024

Solves issue #65

@xoanmm xoanmm mentioned this pull request Jun 4, 2024
@nimakaviani
Copy link
Contributor

I wonder whether we should keep both flags for now with buildName called out as deprecated, and we remove it in a v0.6.0 release? dont want to break people, in case anyone is using it in a CI or something.

@nabuskey
Copy link
Collaborator

nabuskey commented Jun 4, 2024

I wonder whether we should keep both flags for now with buildName called out as deprecated, and we remove it in a v0.6.0 release? dont want to break people, in case anyone is using it in a CI or something.

Agree with this. The issue was written when we didn't have to worry about backward compatibility just yet.

Thanks for this PR and would love to merge it once the flag is preserved.

@nabuskey nabuskey linked an issue Jun 4, 2024 that may be closed by this pull request
@xoanmm
Copy link
Contributor Author

xoanmm commented Jun 4, 2024

@nabuskey @nimakaviani so you suggest to modify the actual PR with both flags to keep backward compatibility showing a message like deprecated, will be removed in future versions use name in buildName flag?

@nabuskey
Copy link
Collaborator

nabuskey commented Jun 4, 2024

@nabuskey @nimakaviani so you suggest to modify the actual PR with both flags to keep backward compatibility showing a message like deprecated, will be removed in future versions use name in buildName flag?

Yep. It should accept either one, name or build-name. If build-name is used, print out a message like you said, then continue. Something like --build-name flag is deprecated and will be removed in a future release. Please use --name instead.

@nabuskey
Copy link
Collaborator

Closing this due to inactivity. Feel free to reopen.

@nabuskey nabuskey closed this Oct 29, 2024
@cmoulliard
Copy link
Contributor

cmoulliard commented Nov 4, 2024

Closing this due to inactivity. Feel free to reopen.

@xoanmm Can you please implement the remark of @nabuskey ? If you cannot finish the PR, can you please mention it ?

@cmoulliard cmoulliard reopened this Nov 4, 2024
@cmoulliard
Copy link
Contributor

Done through a different PR

@cmoulliard cmoulliard closed this Nov 8, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Rename buildName flag
4 participants