Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Rename buildName flag #65

Open
nabuskey opened this issue Oct 25, 2023 · 1 comment
Open

Rename buildName flag #65

nabuskey opened this issue Oct 25, 2023 · 1 comment
Labels
enhancement New feature or request good first issue Good for newcomers

Comments

@nabuskey
Copy link
Collaborator

As pointed out by @cmoulliard in #42 (comment), we should change it.

Let's rename the buildName flag to name. This should correspond to the name of the kind cluster. The default name of localdev is okay with me unless others would like it changed.
@nabuskey nabuskey added the enhancement New feature or request label Oct 25, 2023
@nimakaviani nimakaviani added the good first issue Good for newcomers label Oct 26, 2023
@nimakaviani nimakaviani added this to the v0.2 release milestone Oct 31, 2023
@xoanmm xoanmm mentioned this issue Jun 4, 2024
Closed
@xoanmm
Copy link
Contributor

xoanmm commented Jun 4, 2024

Created PR #277 to solve the mentioned issue

@nabuskey nabuskey linked a pull request Jun 4, 2024 that will close this issue
chore: rename buildName flag to name #277
Closed
@nabuskey nabuskey removed this from the v0.3 release milestone Oct 15, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
enhancement New feature or request good first issue Good for newcomers
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

chore: rename buildName flag to name xoanmm/idpbuilder
3 participants
@nimakaviani @nabuskey @xoanmm