add configuration steps to create a brew release #271
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Nima Kaviani <[email protected]>
blakeromano
reviewed
Jun 3, 2024
| brews: | ||
| - name: idpbuilder | ||
| homepage: "https://cnoe.io" | ||
| repository: |
There was a problem hiding this comment.
Do we want the repository for this to be nimakaviani/homebrew-cnoe or is this for testing? I would imagine maybe we'd want to consider cnoe-io/tap as the repository. It does seem that other big projects like argocd follow the pattern of project/tap for example argo uses argoproj/tap based on documentation here https://docs.brew.sh/Taps#the-brew-tap-command
There was a problem hiding this comment.
ah, an oversight with the owner name. fixed, thanks!
agreed. tap is a better name. renamed the repo to publish to tap.
Signed-off-by: Nima Kaviani <[email protected]>
omrishiv
reviewed
Jun 3, 2024
Signed-off-by: Nima Kaviani <[email protected]>
|
Is this still relevant? |
|
Adding idpbuilder to homebrew is definitely a plus but then the documentation should be updated |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
creates the homebrew formula for idpbuilder
Theoretically everything should work but kinda tricky to test this on the actual repo, since we need to cut a release. we can give it a go after it is reviewed and merged.