Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Improve the install.sh script and remove sudo #273

Open
cmoulliard opened this issue Jun 4, 2024 · 2 comments
Open

Improve the install.sh script and remove sudo #273

cmoulliard opened this issue Jun 4, 2024 · 2 comments
Labels
bug Something isn't working help wanted Extra attention is needed

Comments

@cmoulliard
Copy link
Contributor

TODO

Improve the install.sh script as it asks a sudo password on MacOS machine while that should not not be required.

curl -fsSL https://raw.githubusercontent.com/cnoe-io/idpbuilder/main/hack/install.sh | bash
  % Total    % Received % Xferd  Average Speed   Time    Time     Time  Current
                                 Dload  Upload   Total   Spent    Left  Speed
  0     0    0     0    0     0      0      0 --:--:-- --:--:-- --:--:--     0
100 26.1M  100 26.1M    0     0  8659k      0  0:00:03  0:00:03 --:--:-- 11.0M
idpbuilder 0.4.1 go1.21.5 darwin/arm64
Password:
sudo: a password is required

See : https://docs.brew.sh/FAQ#why-does-homebrew-say-sudo-is-bad

@cmoulliard cmoulliard changed the title Improve the install.sh script Improve the install.sh script and remove sudo Jun 4, 2024
@nabuskey
Copy link
Collaborator

nabuskey commented Jun 4, 2024

Oh yeah it shouldn't use sudo. We need to fix it.

@nabuskey nabuskey added bug Something isn't working help wanted Extra attention is needed labels Jun 4, 2024
@nimakaviani
Copy link
Contributor

I feel like we should get rid of this script and rely on #271 for installation of the binaries. I will find some time to do some final testing of that PR in an organization and then we can merge it.

#271 is pending right now because my tests were with a git user account and not an org setup.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working help wanted Extra attention is needed
Projects
None yet
Development

No branches or pull requests

3 participants