Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix #23: add resources directory and .yaml files. #24

Merged
merged 3 commits into from
Oct 13, 2023

Conversation

hodgiwabi
Copy link
Contributor

No description provided.

@greghaynes
Copy link
Contributor

I think youll need to remove this line too https://github.com/cnoe-io/idpbuilder/blob/main/.gitignore#L5

@hodgiwabi
Copy link
Contributor Author

hodgiwabi commented Oct 13, 2023

It's a bit confusing, but I've verified that these additions allow projects which import idpbuilder to build without the error mentioned in #23 using the following:

  1. Fork cnoe-io/idpbuilder
  2. in the Fork, add the resources directory and YAML files necessary, and remove the .gitignore line.
  3. in the Fork, use a go mod replace directive, to make the fork use the fork, and not the upstream repo. (import statements in the go packages meant that the cnoe-io repo was being pulled for use, not the fork.)
  4. for proof, Autodesk UCP (which imports github.com/cnoe-io/idpbuilder module) builds without errors when using the following in its go.mod: replace github.com/cnoe-io/idpbuilder => github.com/hodgiwabi/idpbuilder v0.0.0-20231013224858-faff040f02f8 where the idpbuilder fork branch includes the changes from steps 2. and 3.

Note that the changes in this PR do not include the changes to the go.mod used for verification—only the .gitignore and resources/*.yaml changes.

@greghaynes
Copy link
Contributor

I think this test fail isnt you - pretty sure tests have been broken, merging.

Thanks @hodgiwabi

@greghaynes greghaynes merged commit 06fb155 into cnoe-io:main Oct 13, 2023
1 check failed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants