Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

When requiring idpbuilder as a module, build fails due to go:embed pattern with invalid matches #23

Closed
hodgiwabi opened this issue Oct 13, 2023 · 2 comments
Closed

When requiring idpbuilder as a module, build fails due to go:embed pattern with invalid matches #23

hodgiwabi opened this issue Oct 13, 2023 · 2 comments

Comments

@hodgiwabi
Copy link
Contributor

Running into the error: pattern resources/*.yaml: no matching files found when using go build.
Referenced line is in /pkg/controllers/crd.go.

From the go embed documentation:

Matches for empty directories are ignored. After that, each pattern in a //go:embed line must match at least one file or non-empty directory.
If any patterns are invalid or have invalid matches, the build will fail.

When running make in idpbuilder, the /pkg/controllers/resources directory is generated. But when requiring idpbuilder in another project, the build fails without the generated directory.
@hodgiwabi
Copy link
Contributor Author

PR created: #24

@hodgiwabi
Copy link
Contributor Author

Verified that the changes in #24 fix the issue. See this comment in the PR.

@hodgiwabi hodgiwabi mentioned this issue Oct 13, 2023
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
1 participant
@hodgiwabi