-
Notifications
You must be signed in to change notification settings - Fork 62
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add docker-registry example package #156
Conversation
Signed-off-by: Greg Haynes <[email protected]>
231d93d
to
5cfa208
Compare
very cool. to some extent addresses this issue as well: #49 |
Signed-off-by: Greg Haynes <[email protected]>
Signed-off-by: Greg Haynes <[email protected]>
…e is idpbuilder password is idpbuilder Signed-off-by: Jesse Sanford <[email protected]>
Can you add a readme similar to other examples we have? |
Signed-off-by: Jesse Sanford <[email protected]>
@jessesanford I agree with @nabuskey we should add a readme. One thing I would definitely include in there is this: https://engineering.autodesk.com/summits/techx2024/proposals/view/87157 - we set a default password and what it is. |
Signed-off-by: Carlos Santana <[email protected]>
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Please a hello world in a README.md
at the root of the new example folder
@@ -166,7 +166,7 @@ data: | |||
locations: | |||
# Examples from a public GitHub repository. | |||
- type: url | |||
target: https://gitea.cnoe.localtest.me:8443/giteaAdmin/idpbuilder-localdev-backstage-entities/src/branch/main/catalog-info.yaml | |||
target: https://gitea.cnoe.localtest.me:8443/giteaAdmin/idpbuilder-localdev-backstage-templates-entities/raw/branch/main/catalog-info.yaml |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
rebase this is already fix in main
ea9c56e
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Yes this is the cherry-pick of that exact commit to this branch I needed it to make sure things were working correctly. The merge to main should be noOp here. Happy to remove it if that is more appropriate.
Do we want to use gitea's container registry or maybe harbor? gitea's would mean not having to deploy an extra resource into the cluster whereas harbor provides supply chain security and image scanning, which could be a nice addition |
As the idpbuilder's gitea server can also be used as images registry, such a package is not needed OR could be proposed as separated ref implementation example |
yeah closing this as #282 takes care of this. Feel free to reopen if you think a separate solution is needed. |
No description provided.