Docker registry fixes #162
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jessesanford
commented
Feb 29, 2024
There was a problem hiding this comment.
We could probably rid of the imageswap admission controller entirely and just use a rewrite with containerd config like so:
kind: Cluster
apiVersion: kind.x-k8s.io/v1alpha4
nodes:
- role: control-plane
image: "kindest/node:v1.27.3"
kubeadmConfigPatches:
- |
kind: InitConfiguration
nodeRegistration:
kubeletExtraArgs:
system-reserved: memory=4Gi
node-labels: "ingress-ready=true"
extraPortMappings:
- containerPort: 443
hostPort: 8443
protocol: TCP
containerdConfigPatches:
- |-
[plugins."io.containerd.grpc.v1.cri".registry.mirrors."registry.cnoe.localtest.me:8443"]
endpoint = ["https://registry.cnoe.localtest.me"]
[plugins."io.containerd.grpc.v1.cri".registry.configs."registry.cnoe.localtest.me".tls]
insecure_skip_verify = true
jessesanford
force-pushed
the
docker-registry-fixes
branch
from
60f1910 to
abd4aec
Compare
admission controller Signed-off-by: Jesse Sanford <[email protected]>
Signed-off-by: Jesse Sanford <[email protected]>
jessesanford
force-pushed
the
docker-registry-fixes
branch
from
abd4aec to
429c41d
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.