Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

add mkdoc to docker image #39

Merged
merged 7 commits into from
Sep 19, 2024
Merged

add mkdoc to docker image #39

Changes from 1 commit
Commits
Show all changes
7 commits
Select commit Hold shift + click to select a range
9d93bd2
add mkdoc to docker image
nabuskey Sep 18, 2024
f8eb826
merge apt commands. pin mkdoc version
nabuskey Sep 19, 2024
2376902
remove sqlite3 from dockerfile
nabuskey Sep 19, 2024
834d0a7
fix mkdocs version
nabuskey Sep 19, 2024
dff1286
clean up Dcokerfile
nabuskey Sep 19, 2024
609287b
remove checksum
nabuskey Sep 19, 2024
b38890b
remove tar file
nabuskey Sep 19, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
8 changes: 8 additions & 0 deletions Dockerfile
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -89,6 +89,14 @@ RUN curl -L -O https://github.com/cnoe-io/cnoe-cli/releases/download/v0.1.0/cnoe
COPY ./cnoe-wrapper.sh /usr/bin/cnoe
RUN chmod +x /usr/bin/cnoe

RUN apt-get update && apt-get install -y python3 python3-pip python3-venv
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

We do a lot of apt work; can we merge these a bit? Also maybe delete the cache before we finish

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I merged it with the kubectl install step above. Cache is mounted so the end image doesn't have any.

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Ah, I see that now, thanks!


ENV VIRTUAL_ENV=/opt/venv
RUN python3 -m venv $VIRTUAL_ENV
ENV PATH="$VIRTUAL_ENV/bin:$PATH"

RUN pip3 install mkdocs-techdocs-core
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Can we add the versions to these so we don't get any unexpected surprises

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Great idea. Done!


# From here on we use the least-privileged `node` user to run the backend.
USER node

Expand Down
Loading