add mkdoc to docker image #39
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Manabu McCloskey <[email protected]>
omrishiv
requested changes
Sep 19, 2024
Dockerfile
Outdated
| RUN python3 -m venv $VIRTUAL_ENV | ||
| ENV PATH="$VIRTUAL_ENV/bin:$PATH" | ||
|
|
||
| RUN pip3 install mkdocs-techdocs-core |
There was a problem hiding this comment.
Can we add the versions to these so we don't get any unexpected surprises
Dockerfile
Outdated
| @@ -89,6 +89,14 @@ RUN curl -L -O https://github.com/cnoe-io/cnoe-cli/releases/download/v0.1.0/cnoe | |||
| COPY ./cnoe-wrapper.sh /usr/bin/cnoe | |||
| RUN chmod +x /usr/bin/cnoe | |||
|
|
|||
| RUN apt-get update && apt-get install -y python3 python3-pip python3-venv | |||
There was a problem hiding this comment.
We do a lot of apt work; can we merge these a bit? Also maybe delete the cache before we finish
There was a problem hiding this comment.
I merged it with the kubectl install step above. Cache is mounted so the end image doesn't have any.
There was a problem hiding this comment.
Ah, I see that now, thanks!
Signed-off-by: Manabu McCloskey <[email protected]>
Signed-off-by: Manabu McCloskey <[email protected]>
Signed-off-by: Manabu McCloskey <[email protected]>
|
Removed sqlite stuff because we don't use it at all. |
Signed-off-by: Manabu McCloskey <[email protected]>
Signed-off-by: Manabu McCloskey <[email protected]>
Signed-off-by: Manabu McCloskey <[email protected]>
omrishiv
approved these changes
Sep 19, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
fixes: #36