Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Move falco gitrepo CR to falco namespace #32

Merged
merged 1 commit into from
Jan 25, 2024
Merged

Move falco gitrepo CR to falco namespace #32

merged 1 commit into from
Jan 25, 2024

Conversation

rossf7
Copy link
Contributor

@rossf7 rossf7 commented Jan 24, 2024

Follow up to #21

Reconciling the kustomization failed because the gitrepo was in the flux-system namespace.

@nikimanoledaki @incertum Should we keep both resources in the falco ns? I'm not sure what the best practice is here.

@nikimanoledaki
Copy link
Contributor

nikimanoledaki commented Jan 24, 2024

Did changing the GitRepository namespace work for you, @rossf7?

Looking at the Flux docs for GitRepository, it mentions that Flux can support multiple so that shouldn't be the issue. flux-system should be the right namespace.

I'm wondering if Flux needs to be bootstrapped a second time, this time to be able to watch the falcosecurity/cncf-green-review-testing repository:

flux bootstrap github --owner=$GITHUB_USER --repository=https://github.com/falcosecurity/cncf-green-review-testing --path=./kustomize

We'd need a GitHub PAT with write access for that repo as we did for this repo. @rossf7, maybe try it with a fork of the repo for now to see if that solves the problem?

@rossf7
Copy link
Contributor Author

rossf7 commented Jan 24, 2024

Did changing the GitRepository namespace work for you

Yes when I created the GitRepository manually the changes were applied.

I'm wondering if Flux needs to be bootstrapped a second time, this time to be able to watch the falcosecurity/cncf-green-review-testing repository:

That's a good shout. I'll do some more investigating on this.

Copy link
Contributor

@nikimanoledaki nikimanoledaki left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM since this worked for you! 👍

@rossf7 rossf7 merged commit 9a8d1e0 into main Jan 25, 2024
1 check passed
@nikimanoledaki nikimanoledaki deleted the falco-ns-fix branch January 25, 2024 15:18
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants