Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

new(falco): add flux deployment config #21

Merged
merged 2 commits into from
Jan 24, 2024
Merged

Conversation

incertum
Copy link
Contributor

Add Falco flux deployment config.

@nikimanoledaki first time using Flux. Looking forward to hearing more tips from you and happy to make any necessary adjustments.

Our new dedicated repo contains relevant docs https://github.com/falcosecurity/cncf-green-review-testing

Action Items:

Tracking:

CC Falco maintainers @leogr @LucaGuerra @maxgio92

@rossf7
Copy link
Contributor

rossf7 commented Jan 11, 2024

@incertum This looks good from a Flux POV. On the knode requirements I added some feedback here falcosecurity/cncf-green-review-testing#2 (comment)

@incertum incertum changed the title wip: new(falco): add flux deployment config new(falco): add flux deployment config Jan 16, 2024
@incertum
Copy link
Contributor Author

Moving out of wip. Good to go and give it try from our side.

Copy link
Contributor

@nikimanoledaki nikimanoledaki left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Amazing, thank you! A couple of changes then LGTM! 🥳 🎉

clusters/falco.yaml Outdated Show resolved Hide resolved
clusters/falco.yaml Outdated Show resolved Hide resolved
Copy link
Contributor

@rossf7 rossf7 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM 🚀

@rossf7
Copy link
Contributor

rossf7 commented Jan 23, 2024

@incertum we've migrated to the new cluster managed with tofu. So we're ready to merge this.

Could you sign the commits? As there is a problem with the DCO check. Thx!

@incertum
Copy link
Contributor Author

@incertum we've migrated to the new cluster managed with tofu. So we're ready to merge this.

Could you sign the commits? As there is a problem with the DCO check. Thx!

I did commit them with sign-off last week, seems all checks have passed. Are there still issues?

@rossf7
Copy link
Contributor

rossf7 commented Jan 23, 2024

I did commit them with sign-off last week, seems all checks have passed. Are there still issues

@incertum the sign-off looks good but could you enable GPG so that signed commits are verified and then rebase please?

incertum and others added 2 commits January 24, 2024 06:30
Co-authored-by: nikimanoledaki <[email protected]>
Signed-off-by: Melissa Kilby <[email protected]>
@rossf7 rossf7 merged commit fbc39f9 into cncf-tags:main Jan 24, 2024
1 check passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants