-
Notifications
You must be signed in to change notification settings - Fork 15
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
new(falco): add flux deployment config #21
Conversation
@incertum This looks good from a Flux POV. On the knode requirements I added some feedback here falcosecurity/cncf-green-review-testing#2 (comment) |
Moving out of wip. Good to go and give it try from our side. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Amazing, thank you! A couple of changes then LGTM! 🥳 🎉
e8b869e
to
1737112
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM 🚀
@incertum we've migrated to the new cluster managed with tofu. So we're ready to merge this. Could you sign the commits? As there is a problem with the DCO check. Thx! |
I did commit them with sign-off last week, seems all checks have passed. Are there still issues? |
@incertum the sign-off looks good but could you enable GPG so that signed commits are verified and then rebase please? |
Signed-off-by: Melissa Kilby <[email protected]>
Co-authored-by: nikimanoledaki <[email protected]> Signed-off-by: Melissa Kilby <[email protected]>
1737112
to
92752c7
Compare
Add Falco flux deployment config.
@nikimanoledaki first time using Flux. Looking forward to hearing more tips from you and happy to make any necessary adjustments.
Our new dedicated repo contains relevant docs https://github.com/falcosecurity/cncf-green-review-testing
Action Items:
Tracking:
CC Falco maintainers @leogr @LucaGuerra @maxgio92