Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: Benchmark param name and add sleep prior to kubectl wait #141

Merged
merged 2 commits into from
Dec 3, 2024
Merged

fix: Benchmark param name and add sleep prior to kubectl wait #141

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
e9c8307
fix: Benchmark duration param name
rossf7 Nov 29, 2024
a4688d4
fix: Revert ns change and add wait
rossf7 Dec 3, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
6 changes: 4 additions & 2 deletions .github/workflows/benchmark-pipeline.yaml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -80,12 +80,12 @@ jobs:
run: |
kubectl apply -f manifest.yaml

sleep 10
sleep 20
rossf7 marked this conversation as resolved.
Show resolved Hide resolved

kubectl wait pod \
--all \
--for=condition=Ready \
--namespace=falco # TODO: Revert to "benchmark" this after merging https://github.com/falcosecurity/cncf-green-review-testing/pull/22
--namespace=benchmark
rossf7 marked this conversation as resolved.
Show resolved Hide resolved

benchmark-job:
runs-on: ubuntu-24.04
Expand All @@ -100,6 +100,8 @@ jobs:
- name: Run the benchmark job
run: |
kubectl apply -f ${{ inputs.benchmark_job_url }}

sleep 20
rossf7 marked this conversation as resolved.
Show resolved Hide resolved

kubectl wait pod \
--all \
Expand Down
2 changes: 1 addition & 1 deletion scripts/project-trigger.sh
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -70,7 +70,7 @@ jq -c '.projects[]' "$json_file" | while read -r project; do
-H "Authorization: Bearer $gh_token" \
-H "X-GitHub-Api-Version: 2022-11-28" \
"https://api.github.com/repos/$workflow_organization_name/$workflow_project_name/actions/workflows/$workflow_dispatcher_file_name/dispatches" \
-d "{\"ref\":\"${git_ref}\",\"inputs\":{\"cncf_project\":\"${proj_name}\",\"benchmark_job_url\":\"${proj_benchmark_manifest_url}\",\"benchmark_job_duration_mins\":\"${proj_benchmark_duration}\",\"config\":\"${config}\",\"version\":\"${latest_proj_version}\"}}")
-d "{\"ref\":\"${git_ref}\",\"inputs\":{\"cncf_project\":\"${proj_name}\",\"benchmark_job_url\":\"${proj_benchmark_manifest_url}\",\"benchmark_job_duration_mins\":\"${proj_benchmark_duration_mins}\",\"config\":\"${config}\",\"version\":\"${latest_proj_version}\"}}")

status_code=$?
if [ $status_code -ne 0 ]; then
Expand Down
Loading