Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: Benchmark param name and add sleep prior to kubectl wait #141

Merged
merged 2 commits into from
Dec 3, 2024

Conversation

rossf7
Copy link
Contributor

@rossf7 rossf7 commented Nov 29, 2024

What type of PR is this?

kind/bug

What this PR does / why we need it:

  • Fixes incorrect param name in trigger script.
  • Adds sleeps before wait in case there is a delay creating pods.
  • Fixes namespace when waiting for falco pods.

Which issue(s) this PR fixes:

Special notes for your reviewer (optional):

@rossf7 rossf7 requested a review from a team as a code owner November 29, 2024 17:28
@rossf7 rossf7 enabled auto-merge (rebase) November 29, 2024 17:40
@rossf7 rossf7 marked this pull request as draft December 3, 2024 16:12
auto-merge was automatically disabled December 3, 2024 16:12

Pull request was converted to draft

@rossf7 rossf7 changed the title fix: Benchmark duration param name fix: Benchmark param name and add sleep prior to kubectl wait Dec 3, 2024
@rossf7 rossf7 marked this pull request as ready for review December 3, 2024 16:31
@rossf7 rossf7 requested a review from dipankardas011 December 3, 2024 16:31
@rossf7 rossf7 merged commit 45185e8 into main Dec 3, 2024
2 checks passed
@rossf7 rossf7 deleted the rf/fix-param branch December 3, 2024 16:42
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants