Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

km-compactify_rectify2 #107

Closed
wants to merge 45 commits into from

Conversation

kenmawer
Copy link
Contributor

Note that the first row may be erroneously removed if all fields (except version) are NA's. However, the handling of NA's is beyond the scope of this branch and rectification of compactify.

kenmawer added 30 commits May 13, 2022 16:08
@brookslogan
Copy link
Contributor

Testing how project board automation reacts: this PR addresses #62.

@brookslogan
Copy link
Contributor

Resolves #62.

@brookslogan
Copy link
Contributor

Not sure if this should be a separate PR or commits pushed onto #101. The former does might allow for a bit easier use of "/compare" GitHub endpoints to compare associated branches since the branches names are at the top of the commit (although this can still be accomplished in the latter setup by copying the desired commit hashes from the PR conversation. The latter probably allows for easier tracking of which requested changes/comments are being addressed due to the "out of date" mechanism (but harder to see what they were originally about). For now, I'm going to go ahead and try to push these changes back onto #101's branch and close this one.

@kenmawer
Copy link
Contributor Author

Thankfully this pull request doesn't include this, but when pulling, I accidentally pushed a badly butchered commit that starts with e90a9 and I can't find how to un-push it to the last good commit 7c4d9.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants