-
Notifications
You must be signed in to change notification settings - Fork 8
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add option to compactify issue data in epi_archive
#62
Comments
@lcbrooks Thanks for the idea! I think it sounds like a good idea. Not sure if |
Regarding the naming: I just didn't want to call it |
I can help with this. |
I completed this and added tests for compactify. However, it still needs reviewing, so feel free to suggest improvements, such as if you want the printing to be more informative or have some way to prevent invalid entries for the compactify variable. |
Is this in a PR already? If so, could you please point me to it; otherwise, could you open a PR? |
epi_archive
s can be formed based on a conglomeration of full snapshots, issue data with duplicate re-reporting, and/or minimal patch-like issues. Some space (unsure about time) can be saved by removing rows that match LOCF of previous issues. Space can be essential if we are attempting in-memory analysis.Proposal: introduce a constructor argument
compactify
:TRUE
: remove unnecessary rows to give same LOCF results. Make sure to maintain the samemax_issue
value as the original data.FALSE
: leave data as-isNULL
): same asTRUE
except message the user if this actually changed the data, and telling them how to silence the messageUse cases:
object.size
says is 40MB--50MB down to ~10MB, but at the county level it might matter more.)The text was updated successfully, but these errors were encountered: